remove copying the dir doc and changelog in deploy.sh because of the two dirs not exist #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jovany-wang
reviewed
Jan 9, 2019
deploy.sh
Outdated
| cp -rf ${CWD_DIR}/doc ${DEPLOY_BUILD_HOME}/ | ||
| cp -rf ${CWD_DIR}/changelog ${DEPLOY_BUILD_HOME}/ | ||
| #cp -rf ${CWD_DIR}/doc ${DEPLOY_BUILD_HOME}/ | ||
| #cp -rf ${CWD_DIR}/changelog ${DEPLOY_BUILD_HOME}/ |
Contributor
There was a problem hiding this comment.
Could you please tell the reason for commenting these lines?
If the ${CWD_DIR}/doc is not existed, I think we should fix the issue that ${CWD_DIR}/doc could not be found instead of commenting these directly?
Contributor
|
dir ${CWD_DIR}/doc and ${CWD_DIR}/changelog have been removed in version 1.2.0 not long ago |
lemonzone2010
changed the title
ShannonDing
approved these changes
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I run deploy.sh and I get the error :