Skip to content

[Enhancement] IndexStoreService use forceShutdown when disk is not writable #9838

@RongtongJin

Description

@RongtongJin

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

When the disk becomes unwritable, IndexStoreService.shutdown() method will wait for the timeStoreTable to be empty (waiting for index files to be uploaded), which can cause the shutdown process to hang indefinitely. This is problematic because:

  1. If the disk is not writable, waiting for upload operations to complete is futile and can cause unnecessary delays
  2. The shutdown process should be able to complete quickly even when the disk is in an unwritable state
  3. The current implementation can lead to resource leaks if the shutdown process is blocked

Motivation

When the disk becomes unwritable, IndexStoreService.shutdown() method will wait for the timeStoreTable to be empty (waiting for index files to be uploaded), which can cause the shutdown process to hang indefinitely. This is problematic because:

  1. If the disk is not writable, waiting for upload operations to complete is futile and can cause unnecessary delays
  2. The shutdown process should be able to complete quickly even when the disk is in an unwritable state
  3. The current implementation can lead to resource leaks if the shutdown process is blocked

Describe the Solution You'd Like

When the disk is not writable, IndexStoreService should use forceShutdown() instead of shutdown() to immediately stop the service without waiting for upload operations to complete.

Describe Alternatives You've Considered

No

Additional Context

No

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions