-
Notifications
You must be signed in to change notification settings - Fork 12k
[ROCKETMQ-239]fix query message by time and fix get queue offset by time #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1 similar comment
2 similar comments
1 similar comment
2 similar comments
1 similar comment
1 similar comment
|
@vongosling @zhouxinyu @Jaskey please help a review. |
| * | ||
| * @param topic Topic of the message. | ||
| * @param queueId Queue ID. | ||
| * @param timestamp Timestamp to look up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing the JavaDoc of new param isGetTimeLast here. BTW, isGetTimeLast is confused~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,and the JavaDoc if param isGetTimeLast has been added
|
Please help a review,Accuracy message offset search by store time has been fixed. |
|
I scrutinized the code changes. Corner cases are handled properly and things look good except variables/method naming. |
|
@lindzh I will close the pr, if you happened to the same question, please let me know. |
When using queryMessageByTime or searchOffsetByTime or resetOffsetByTime , DefaultMessageStore return offset is not so accurate as we want.