Skip to content

Conversation

@lindzh
Copy link
Contributor

@lindzh lindzh commented Jul 6, 2017

When using queryMessageByTime or searchOffsetByTime or resetOffsetByTime , DefaultMessageStore return offset is not so accurate as we want.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 39.417% when pulling c37adb5 on lindzh:fix_query_message_by_time into d414920 on apache:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 39.417% when pulling c37adb5 on lindzh:fix_query_message_by_time into d414920 on apache:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 39.511% when pulling 2c24b67 on lindzh:fix_query_message_by_time into d414920 on apache:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 39.511% when pulling 2c24b67 on lindzh:fix_query_message_by_time into d414920 on apache:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 39.511% when pulling 2c24b67 on lindzh:fix_query_message_by_time into d414920 on apache:master.

@coveralls
Copy link

coveralls commented Aug 9, 2017

Coverage Status

Coverage increased (+0.5%) to 39.627% when pulling a8835c4 on lindzh:fix_query_message_by_time into d414920 on apache:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 39.627% when pulling a8835c4 on lindzh:fix_query_message_by_time into d414920 on apache:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 39.7% when pulling f2f2fba on lindzh:fix_query_message_by_time into d414920 on apache:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 39.7% when pulling f2f2fba on lindzh:fix_query_message_by_time into d414920 on apache:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 39.7% when pulling f2f2fba on lindzh:fix_query_message_by_time into d414920 on apache:master.

@coveralls
Copy link

coveralls commented Aug 11, 2017

Coverage Status

Coverage increased (+0.6%) to 39.711% when pulling d1f2b9d on lindzh:fix_query_message_by_time into d414920 on apache:master.

@lindzh lindzh changed the base branch from master to develop August 11, 2017 08:01
@coveralls
Copy link

coveralls commented Aug 11, 2017

Coverage Status

Coverage increased (+0.6%) to 39.648% when pulling 8302bb8 on lindzh:fix_query_message_by_time into aa1c757 on apache:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 39.648% when pulling 8302bb8 on lindzh:fix_query_message_by_time into aa1c757 on apache:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 39.637% when pulling e3988d3 on lindzh:fix_query_message_by_time into 332df78 on apache:develop.

1 similar comment
@coveralls
Copy link

coveralls commented Aug 14, 2017

Coverage Status

Coverage increased (+0.6%) to 39.637% when pulling e3988d3 on lindzh:fix_query_message_by_time into 332df78 on apache:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 39.508% when pulling 9ebcd6b on lindzh:fix_query_message_by_time into 1bbd4cd on apache:develop.

@dongeforever
Copy link
Member

@vongosling @zhouxinyu @Jaskey please help a review.

*
* @param topic Topic of the message.
* @param queueId Queue ID.
* @param timestamp Timestamp to look up.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the JavaDoc of new param isGetTimeLast here. BTW, isGetTimeLast is confused~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes,and the JavaDoc if param isGetTimeLast has been added

@coveralls
Copy link

coveralls commented Dec 14, 2017

Coverage Status

Coverage increased (+0.6%) to 40.584% when pulling ddb1cc7 on lindzh:fix_query_message_by_time into a096580 on apache:develop.

@lindzh
Copy link
Contributor Author

lindzh commented Dec 14, 2017

Please help a review,Accuracy message offset search by store time has been fixed.

@lizhanhui
Copy link
Contributor

I scrutinized the code changes. Corner cases are handled properly and things look good except variables/method naming.

@vongosling
Copy link
Member

@lindzh I will close the pr, if you happened to the same question, please let me know.

@vongosling vongosling closed this Jul 14, 2018
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Jun 25, 2019
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Jun 25, 2019
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants