Skip to content

Conversation

@fuyou001
Copy link
Contributor

@fuyou001 fuyou001 commented Nov 2, 2017

What is the purpose of the change

Increasing name server component network socket buffer size, improve broker register speed, resolve the issue ROCKETMQ-308

Brief changelog

delete NamesrvStartup set network socket buffer code,using default value.

delete code

  if (null == System.getProperty(NettySystemConfig.COM_ROCKETMQ_REMOTING_SOCKET_SNDBUF_SIZE)) {
            NettySystemConfig.socketSndbufSize = 4096;
        }

        if (null == System.getProperty(NettySystemConfig.COM_ROCKETMQ_REMOTING_SOCKET_RCVBUF_SIZE)) {
            NettySystemConfig.socketRcvbufSize = 4096;
        }

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 38.896% when pulling d21a184 on fuyou001:ROCKETMQ-308 into 3a0451b on apache:master.

@zhouxinyu
Copy link
Member

Thanks,
but please fork and merge your contribution to develop master, and use a meaningful title.

@zhouxinyu zhouxinyu changed the title Rocketmq 308 [ROCKETMQ-308] Increasing name server component network socket buffer size Nov 2, 2017
@zhouxinyu zhouxinyu changed the base branch from master to develop November 3, 2017 02:49
@zhouxinyu
Copy link
Member

I changed the target branch, but it seems your PR is based on the wrong codebase, please help fix it.

@zhouxinyu
Copy link
Member

Hi @fuyou001, It seems that only this commit should be merged, please help fix this PR.

@zhouxinyu
Copy link
Member

duplicated.

@zhouxinyu zhouxinyu closed this Dec 1, 2017
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
…to the real one, and msgExt's size should be reset since buffer maybe overflow.
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
…, the messageExt's msgId is not the same with the msgId in sendResult
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
…UNITY_TIME_IN_SECONDS time, put back into half topic, but not send check message
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
…alf message is still in transaction time, break the check
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants