Skip to content

Conversation

@zhouxinyu
Copy link
Member

What is the purpose of the change

Resolve issue ROCKETMQ-312.

QueryMessageProcessor and PullMessageProcessor are sharing the same thread pool, should split it.

Brief changelog

Add a query message executor to accept and handle QUERY_MESSAGE and VIEW_MESSAGE_BY_ID requests.

Verifying this change

Start the server, and submit some query message requests, then verify the functionality. Also
the logger RocketmqWaterMark will trace the capacity info of the related queue.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ROCKETMQ-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 39.128% when pulling 717117b on zhouxinyu:ROCKETMQ-312 into cba3089 on apache:develop.

Copy link
Contributor

@shroman shroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. +1

Copy link
Contributor

@vsair vsair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vongosling
Copy link
Member

+1

zhouxinyu added a commit that referenced this pull request Dec 1, 2017
Author: yukon <yukon@apache.org>

Closes #192 from zhouxinyu/ROCKETMQ-312.
@zhouxinyu
Copy link
Member Author

Merged!

@zhouxinyu zhouxinyu closed this Dec 1, 2017
JiaMingLiu93 pushed a commit to JiaMingLiu93/rocketmq that referenced this pull request May 28, 2020
Author: yukon <yukon@apache.org>

Closes apache#192 from zhouxinyu/ROCKETMQ-312.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants