Skip to content

Conversation

@fuyou001
Copy link
Contributor

What is the purpose of the change

when msg process expired, msg send back must sync change process queue msg size .

Brief changelog

processQueeu#cleanExpiredMsg method reuse removeMessage method to delete expired msg

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ROCKETMQ-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 39.111% when pulling 6f5e01e on fuyou001:ROCKETMQ-314-1 into cba3089 on apache:develop.

@zhouxinyu
Copy link
Member

LGTM, It could be better if we add a unit test for this case~

@vongosling
Copy link
Member

Thing could be better, If we could have unit for removeMessage method @fuyou001

@zhouxinyu zhouxinyu merged commit 6b408ec into apache:develop Dec 8, 2017
@vongosling vongosling added this to the 4.3.0 milestone Jun 25, 2018
renshuaibing-aaron pushed a commit to renshuaibing-aaron/rocketmq that referenced this pull request Apr 13, 2020
[ROCKETMQ-314] msg send back must sync change process queue msg size
JiaMingLiu93 pushed a commit to JiaMingLiu93/rocketmq that referenced this pull request May 28, 2020
[ROCKETMQ-314] msg send back must sync change process queue msg size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants