Skip to content

Conversation

@dongeforever
Copy link
Member

What is the purpose of the change

Avoid message loss when shutdown with dispatch behind

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ROCKETMQ-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@dongeforever dongeforever changed the base branch from master to develop November 30, 2017 12:52
@dongeforever dongeforever changed the title [Rocketmq-320]Message loss when shutdown with dispatch behind [ROCKETMQ-320]Message loss when shutdown with dispatch behind Nov 30, 2017
@dongeforever dongeforever changed the title [ROCKETMQ-320]Message loss when shutdown with dispatch behind [ROCKETMQ-320] Message loss when shutdown with dispatch behind Nov 30, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 39.171% when pulling c572d03 on dongeforever:ROCKETMQ-320 into 4926187 on apache:develop.

Copy link
Member

@zhouxinyu zhouxinyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@vongosling
Copy link
Member

+1, Cool~

Copy link
Contributor

@shroman shroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Why do we need shutDownNormal here?

@zhouxinyu
Copy link
Member

@shroman It's only for unit test, any better solution?

@shroman
Copy link
Contributor

shroman commented Dec 7, 2017

@zhouxinyu I would throw an exception from DefaultMessageStore#shutdown if something goes wrong. This will also simplify unit tests -- no special flags are needed.

@vongosling vongosling merged commit c674137 into apache:develop Dec 13, 2017
@vongosling vongosling added this to the 4.3.0 milestone Jun 25, 2018
renshuaibing-aaron pushed a commit to renshuaibing-aaron/rocketmq that referenced this pull request Apr 13, 2020
JiaMingLiu93 pushed a commit to JiaMingLiu93/rocketmq that referenced this pull request May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants