Skip to content

Conversation

@fuyou001
Copy link
Contributor

What is the purpose of the change

Increasing name server component network socket buffer size, improve broker register speed, resolve the issue ROCKETMQ-308

Brief changelog

delete NamesrvStartup set network socket buffer code,using default value.

delete code

  if (null == System.getProperty(NettySystemConfig.COM_ROCKETMQ_REMOTING_SOCKET_SNDBUF_SIZE)) {
            NettySystemConfig.socketSndbufSize = 4096;
        }

        if (null == System.getProperty(NettySystemConfig.COM_ROCKETMQ_REMOTING_SOCKET_RCVBUF_SIZE)) {
            NettySystemConfig.socketRcvbufSize = 4096;
        }

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 39.135% when pulling 6f0f370 on fuyou001:ROCKETMQ-308-1 into 4926187 on apache:develop.

@zhouxinyu
Copy link
Member

LGTM~

@dongeforever
Copy link
Member

LGTM

@vongosling vongosling merged commit 5459215 into apache:develop Dec 13, 2017
@vongosling vongosling added this to the 4.3.0 milestone Jun 25, 2018
renshuaibing-aaron pushed a commit to renshuaibing-aaron/rocketmq that referenced this pull request Apr 13, 2020
… size (apache#199)

* [ROCKETMQ-308]  nameserver socket buffer use default value.

(cherry picked from commit e9fcb07)

* [ROCKETMQ-308]  delete unused import

(cherry picked from commit 3bcefff)
JiaMingLiu93 pushed a commit to JiaMingLiu93/rocketmq that referenced this pull request May 28, 2020
… size (apache#199)

* [ROCKETMQ-308]  nameserver socket buffer use default value.

(cherry picked from commit e9fcb07)

* [ROCKETMQ-308]  delete unused import

(cherry picked from commit 3bcefff)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants