Skip to content

Conversation

@lindzh
Copy link
Contributor

@lindzh lindzh commented Dec 28, 2017

What is the purpose of the change

After using updateTopic command to change retry queue nums to more than 1 ,but consumer consume send back always choose 0. After change retry queue nums, it may randomly send to all queues.

Brief changelog

When consumer send back messages, send to retry topic queues randomly rather than send to only one using consumeSubConfig.

Verifying this change

This is a trivial change.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ROCKETMQ-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

lindzh added 22 commits August 11, 2017 15:55
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 39.886% when pulling 7fef3ba on lindzh:fix_retry_dlq_nums into cc0b3d0 on apache:develop.

@vongosling
Copy link
Member

I will close the pr, if you happened to the same question, please let me know.

@vongosling vongosling closed this Jul 14, 2018
@zhwq1216
Copy link

I have the same problem. I try the lastest version 4.4.0, it is still not fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants