-
Notifications
You must be signed in to change notification settings - Fork 12k
[ROCKETMQ-355] Client asyncSend is not fully async #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @lindzh , No need to close the previous PR and open a new, while the comments will be lost. |
Contributor
Author
|
@zhouxinyu,yeah, keep comment is a good idea for continuous develop. At first I want to limit the send request and using network semaphore as send signal,but after doing that I found it was a mistake and open another PR for concise and speed. |
Member
lizhanhui
pushed a commit
to lizhanhui/rocketmq
that referenced
this pull request
Dec 10, 2020
…wait for committedWhere coming up with maxWroteOffset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Client asyncSend is not fully async because of param validation, connection status check and get route info may cause exception,and these exceptions is called in user thread may cause biz stop.
Brief changelog
Make client asyncSend fully async.
Verifying this change
This is a trivial change.
Follow this checklist to help us incorporate your contribution quickly and easily:
[ROCKETMQ-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.