Skip to content

Conversation

@lindzh
Copy link
Contributor

@lindzh lindzh commented Jan 25, 2018

What is the purpose of the change

Client asyncSend is not fully async because of param validation, connection status check and get route info may cause exception,and these exceptions is called in user thread may cause biz stop.

Brief changelog

Make client asyncSend fully async.

Verifying this change

This is a trivial change.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ROCKETMQ-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

lindzh added 22 commits August 11, 2017 15:55
@coveralls
Copy link

coveralls commented Jan 25, 2018

Coverage Status

Coverage increased (+0.2%) to 40.138% when pulling 0e09e26 on lindzh:fix_asyncSend into a096580 on apache:develop.

@zhouxinyu
Copy link
Member

Hi @lindzh , No need to close the previous PR and open a new, while the comments will be lost.

@lindzh
Copy link
Contributor Author

lindzh commented Feb 5, 2018

@zhouxinyu,yeah, keep comment is a good idea for continuous develop. At first I want to limit the send request and using network semaphore as send signal,but after doing that I found it was a mistake and open another PR for concise and speed.

@vongosling
Copy link
Member

Thanks @lindzh . I have noticed another PR for this question
#318, I am willing to help guys to polish the modification. Let's work together in the new PR.

@vongosling vongosling closed this May 29, 2018
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
…wait for committedWhere coming up with maxWroteOffset.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants