-
Notifications
You must be signed in to change notification settings - Fork 32
feat(r/sedonadb): Add sd_write_parquet() to R bindings
#210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements the sd_write_parquet() function for the R bindings of sedonadb, enabling users to write DataFrames to (Geo)Parquet files with various options for partitioning, sorting, and GeoParquet metadata handling.
Key changes:
- Added R function
sd_write_parquet()with comprehensive parameter validation and configurable output options - Implemented underlying Rust functionality in
dataframe.rswith support for partitioning, sorting, and GeoParquet versions - Added comprehensive test coverage for various write scenarios including geometry data handling
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| r/sedonadb/R/dataframe.R | Implements the main sd_write_parquet() R function with parameter validation |
| r/sedonadb/src/rust/src/dataframe.rs | Adds Rust implementation to_parquet() method with GeoParquet options |
| r/sedonadb/tests/testthat/test-dataframe.R | Comprehensive test suite covering all write scenarios |
| r/sedonadb/R/000-wrappers.R | Auto-generated wrapper for the new Rust function |
| r/sedonadb/src/init.c | C binding registration for the new function |
| r/sedonadb/src/rust/api.h | C header declaration for the new function |
| r/sedonadb/src/rust/Cargo.toml | Added datafusion-expr dependency |
| r/sedonadb/man/sd_write_parquet.Rd | Documentation for the new function |
| r/sedonadb/NAMESPACE | Export declaration for the new function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Implements the (Geo)Parquet writer in the R bindings:
Created on 2025-10-10 with reprex v2.1.1