fix(c/sedona-c2geography): Remove outdated feature cxx17 from abseil in vcpkg.json
#235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
cargo buildon my Windows fails with this vcpkg error.It seems this is because feature
cxx17is removed by this commit because CXX17 is now its baseline.https://github.com/microsoft/vcpkg/pull/46867/files
However, during preparing this pull request, I found vcpkg is pinned to this commit on CI, so probably this pull request doesn't pass the CI check.
sedona-db/.github/workflows/python-wheels.yml
Line 41 in c17260b
On the other hand, I think the contributors' guide assumes the contributor runs with the latest vcpkg... So, I'm not sure if this change is necessary or not. Please feel free to close if this is too early.