Skip to content

Conversation

@yutannihilation
Copy link
Contributor

Currently, cargo build on my Windows fails with this vcpkg error.

  error: abseil@20250512.1 does not have required feature cxx17 needed by

It seems this is because feature cxx17 is removed by this commit because CXX17 is now its baseline.

https://github.com/microsoft/vcpkg/pull/46867/files

However, during preparing this pull request, I found vcpkg is pinned to this commit on CI, so probably this pull request doesn't pass the CI check.

VCPKG_REF: 5a01de756c28279ddfdd2b061d1c75710a6255fa

On the other hand, I think the contributors' guide assumes the contributor runs with the latest vcpkg... So, I'm not sure if this change is necessary or not. Please feel free to close if this is too early.

Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI seems fine...thanks! I am a little unclear on vcpkg.json and under which circumstances it is used (this was copied from the DuckDB extension which I think does actively use it).

@paleolimbot paleolimbot merged commit 04aff75 into apache:main Oct 21, 2025
12 checks passed
@yutannihilation yutannihilation deleted the fix/sedona-s2geography-vcpkg branch October 21, 2025 23:59
@yutannihilation
Copy link
Contributor Author

CI seems fine

This was unexpected... I checked the log, and it seems abseil is actually built and there was no error. So, I guess cxx17 feature was not necessary from before...? (DuckDB might need this in order to aim for various platforms)

https://github.com/apache/sedona-db/actions/runs/18696004664/job/53313525718:

2025-10-21T20:00:23.5568873Z D:\a\sedona-db\sedona-db\ci\scripts\custom-triplets\x64-windows-dynamic-release.cmake: info: loaded overlay triplet from here
2025-10-21T20:00:23.5952688Z Downloading https://github.com/abseil/abseil-cpp/archive/20250127.1.tar.gz -> abseil-abseil-cpp-20250127.1.tar.gz
2025-10-21T20:00:23.7953059Z Successfully downloaded abseil-abseil-cpp-20250127.1.tar.gz
2025-10-21T20:00:24.0720777Z -- Extracting source D:/a/sedona-db/sedona-db/vcpkg/downloads/abseil-abseil-cpp-20250127.1.tar.gz

Anyway, glad to see this change is fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants