docs: Update contributors guide about Windows DLL path #291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweaks the contributors guide in two minor points about the Windows case.
First one is that, with the current
PATH, I get this error when I runcargo run -p sedona-cli. I mean, it successfully compiles, but fails to run. It seems this is because I forgot to add a path to vcpkg's DLLs. So, I added one.Second,
PKG_CONFIG_PATHrefers toVCPKG_ROOT/installed/x64-windows-dynamic-release/lib/pkgconfig/, but I guess the triple should bex64-windowsinstead ofx64-windows-dynamic-releasebecause the guide doesn't specify$env:VCPKG_DEFAULT_TRIPLET = 'x64-windows-dynamic-release'(Guessing from the CI setting, this should be used only when building Python?) It seems either works fine, though.Note that, while this allows me to run the CLI, I'm still failing to load the sedonadb module on Python. I hope we can eventually find how to make it work...