Skip to content

Conversation

@jesspav
Copy link
Collaborator

@jesspav jesspav commented Nov 13, 2025

Separated out the PR for generating tiled random rasters because it was overlapping in multiple tasks (cropping, reading/writing, benchmarking).

Screenshot of the result made by writing the three bands as UInt8 with geotiff and opening with Preview. Note the no-data values in the 4 corners, which will be important for testing.
Screenshot 2025-11-13 at 09 20 57

@jesspav jesspav requested a review from Copilot November 13, 2025 17:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functionality to generate tiled random raster test data with nodata values at the corners. The implementation uses fastrand instead of rand for better performance in benchmarking scenarios.

  • Adds generate_tiled_rasters function to create a grid of raster tiles with random pixel values
  • Implements helper functions for corner position detection and random band data generation
  • Adds utility functions raster_arrays_equal and raster_equal for comparing raster data structures

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 6 comments.

File Description
rust/sedona-testing/src/rasters.rs Adds new functions for generating tiled rasters with random data, helper functions for nodata value placement, and raster comparison utilities
rust/sedona-testing/Cargo.toml Adds fastrand dependency to the testing package
Cargo.toml Adds fastrand workspace dependency at version 2.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to consider now or later! Thank you!

@paleolimbot paleolimbot merged commit 076f62b into apache:main Nov 14, 2025
12 checks passed
@paleolimbot paleolimbot added this to the 0.2.0 milestone Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants