Skip to content

Conversation

@zhangfengcdt
Copy link
Member

@zhangfengcdt zhangfengcdt commented Sep 12, 2025

Address #68

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation for the barrier function and demonstrates its usage in KNN join scenarios to address optimization control needs. The documentation explains how to prevent filter pushdown and control predicate evaluation order in complex spatial joins.

  • Adds a new "Optimization Barrier" section explaining the barrier function
  • Provides a practical example showing barrier usage in KNN joins with filtering
  • Demonstrates runtime evaluation control for complex spatial query optimization
Comments suppressed due to low confidence (1)

docs/reference/sql-joins.md:45

  • Missing punctuation. Should be 'Example:' with a colon after 'Example'.
### Example For each city, find the 5 other closest cities.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@zhangfengcdt zhangfengcdt marked this pull request as ready for review September 12, 2025 14:45
@jiayuasu
Copy link
Member

jiayuasu commented Sep 12, 2025

LGTM overall. Can you elaborate a bit more in the doc about why applying the filter before and after the KNN actually have different semantic meanings?

@zhangfengcdt
Copy link
Member Author

LGTM overall. Can you elaborate a bit more in the doc about why applying the filter before and after the KNN actually have different semantic meanings?

Sure, explanations have been added with examples to the doc.

Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jiayuasu jiayuasu merged commit 4948319 into apache:main Sep 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants