Skip to content

Fix missing SRID on EPSG:4326 #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 14, 2025
Merged

Fix missing SRID on EPSG:4326 #79

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4dc11a6
Fix missing srid on lnglat
jesspav Sep 13, 2025
54938af
squash me
jesspav Sep 13, 2025
4ba8eb3
minor change to give lnglat control of its srid
jesspav Sep 13, 2025
57827bc
squash me
jesspav Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions rust/sedona-schema/src/crs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,10 @@ impl LngLat {
pub fn is_authority_code_lnglat(string_value: &str) -> bool {
string_value == "OGC:CRS84" || string_value == "EPSG:4326"
}

pub fn srid() -> Option<u32> {
Some(4326)
}
}

/// Implementation of an authority:code CoordinateReferenceSystem
Expand Down Expand Up @@ -213,6 +217,8 @@ impl CoordinateReferenceSystem for AuthorityCode {
fn srid(&self) -> Result<Option<u32>> {
if self.authority.eq_ignore_ascii_case("EPSG") {
Ok(self.code.parse::<u32>().ok())
} else if LngLat::is_lnglat(self) {
Ok(LngLat::srid())
} else {
Ok(None)
}
Expand Down Expand Up @@ -287,9 +293,8 @@ impl CoordinateReferenceSystem for ProjJSON {
let authority_code_opt = self.to_authority_code()?;
if let Some(authority_code) = authority_code_opt {
if LngLat::is_authority_code_lnglat(&authority_code) {
return Ok(Some(4326));
}
if let Some((_, code)) = AuthorityCode::split_auth_code(&authority_code) {
return Ok(LngLat::srid());
} else if let Some((_, code)) = AuthorityCode::split_auth_code(&authority_code) {
return Ok(code.parse::<u32>().ok());
}
}
Expand Down Expand Up @@ -391,5 +396,9 @@ mod test {
Some("EPSG:4269".to_string())
);
assert_eq!(new_crs.unwrap().srid().unwrap(), Some(4269));

let value: Value = serde_json::from_str("\"EPSG:4326\"").unwrap();
let new_crs = deserialize_crs(&value).unwrap();
assert_eq!(new_crs.clone().unwrap().srid().unwrap(), Some(4326));
}
}