Support to config custom decryption methods for kafka configurations and fix bug kafka-reporter-plugin exception "java.lang.NoClassDefFoundError: com/google/gson/Gson"` #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and fix bug `kafka-reporter-plugin-8.15.0 throw exception "java.lang.NoClassDefFoundError: com/google/gson/Gson"`
wu-sheng
reviewed
May 25, 2023
CHANGES.md
Outdated
| * Support Grizzly Trace | ||
| * Fix possible IllegalStateException when using Micrometer. | ||
|
|
||
| * Support to config custom decryption methods for kafka configurations and fix bug `kafka-reporter-plugin-8.15.0 throw exception "java.lang.NoClassDefFoundError: com/google/gson/Gson"` |
Member
There was a problem hiding this comment.
This should be two features, rather than one.
wu-sheng
reviewed
May 25, 2023
| | `plugin.kafka.topic_management` | Specify which Kafka topic name for the register or heartbeat data of Service Instance to report to. | SW_PLUGIN_KAFKA_TOPIC_MANAGEMENT | `skywalking-managements` | | ||
| | `plugin.kafka.topic_logging` | Specify which Kafka topic name for the logging data to report to. | SW_PLUGIN_KAFKA_TOPIC_LOGGING | `skywalking-logging` | | ||
| | `plugin.kafka.namespace` | isolate multi OAP server when using same Kafka cluster (final topic name will append namespace before Kafka topics with `-` ). | SW_KAFKA_NAMESPACE | `` | | ||
| | `plugin.kafka.decrypt_class` | Specify which class to decrypt encrypted configuration of kafka.You can set encrypted information in `plugin.kafka.producer_config_json` or `plugin.kafka.producer_config` if you need. | SW_KAFKA_DECRYPT_CLASS | `` | |
Member
There was a problem hiding this comment.
This doc should be updated as well, including
- Which artifact and version should the developer depend on to develop this? Which interface should be implemented?
- Where to put the packaged codes
wu-sheng
changed the title
kafka-reporter-plugin-8.15.0 throw exception "java.lang.NoClassDefFoundError: com/google/gson/Gson"
wu-sheng
reviewed
May 25, 2023
Comment on lines
+150
to
+156
| Class<?> decryptClazz = Class.forName(Kafka.DECRYPT_CLASS); | ||
| Method decryptMethod = decryptClazz.getMethod(Kafka.DECRYPT_METHOD, Map.class); | ||
| return (Map<String, String>) decryptMethod.invoke(decryptClazz.newInstance(), config); | ||
| } catch (ClassNotFoundException | NoSuchMethodException | InstantiationException | IllegalAccessException | InvocationTargetException e) { | ||
| // ignore | ||
| LOGGER.warn("The decrypt class {} is not exist, exception:{}.", Kafka.DECRYPT_CLASS, e); | ||
| return config; |
Member
There was a problem hiding this comment.
If you want to do in this way, please indicate in the docs, what method should be written.
Member
You should do code style check. |
Member
|
As this PR is not updated, GSON part is being fixed by #538 as well. |
Contributor
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Bug] fix bug
kafka-reporter-plugin-8.15.0 throw exception "java.lang.NoClassDefFoundError: com/google/gson/Gson"Fix apache/skywalking#10848
skywalking-java support to decrypt password of kafka with SASL_SSL enabled
If this is non-trivial feature, paste the links/URLs to the design doc.
Update the documentation to include this new feature.
Tests(including UT, IT, E2E) are added to verify the new feature.
If it's UI related, attach the screenshots below.
Closes #<10848>.
Update the
CHANGESlog.