[Feature] Support to configure custom decode method for kafka configurations #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and fix bug `kafka-reporter-plugin-8.15.0 throw exception "java.lang.NoClassDefFoundError: com/google/gson/Gson"`
Member
|
I remember there was a discussion about this, please link to the issue. |
Contributor
Author
discussion is a bug |
wu-sheng
requested changes
May 27, 2023
...er-plugin/src/main/java/org/apache/skywalking/apm/agent/core/kafka/KafkaProducerManager.java
Outdated
Show resolved
Hide resolved
...er-plugin/src/main/java/org/apache/skywalking/apm/agent/core/kafka/KafkaProducerManager.java
Outdated
Show resolved
Hide resolved
GuiSong01
changed the title
GuiSong01
changed the title
wu-sheng
reviewed
May 31, 2023
...er-plugin/src/main/java/org/apache/skywalking/apm/agent/core/kafka/KafkaProducerManager.java
Outdated
Show resolved
Hide resolved
…c/main/java/org/apache/skywalking/apm/agent/core/kafka/KafkaProducerManager.java
4 tasks
wu-sheng
approved these changes
May 31, 2023
Member
wu-sheng
left a comment
wu-sheng
left a comment
There was a problem hiding this comment.
@GuiSong01 I rewrote the docs for you. Others are good for me.
Sorry for letting you wait for so long, take a long time to recovery from jetleg
yangyulely
pushed a commit
to yangyulely/skywalking-java
that referenced
this pull request
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support to configure custom decryption methods for kafka configurations
If this is non-trivial feature, paste the links/URLs to the design doc.
Update the documentation to include this new feature.
Tests(including UT, IT, E2E) are added to verify the new feature.
If it's UI related, attach the screenshots below.
If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #10815.
Update the
CHANGESlog.