Add skywalking satellite support#83
Conversation
mrproliu
commented
Nov 24, 2021
- Support using satellite as a gateway
- upgrade E2E as infra-e2e
| helm install "${SKYWALKING_RELEASE_NAME}" ${REPO}/skywalking -n "${SKYWALKING_RELEASE_NAMESPACE}" \ | ||
| --set satellite.enabled=true \ | ||
| --set satellite.image.tag=v0.3.0 | ||
| ``` |
There was a problem hiding this comment.
We should add description about user should set service address to satellite instead of oap, right?
There was a problem hiding this comment.
been added, please take a look.
hanahmily
left a comment
There was a problem hiding this comment.
Some nits of manifests.
|
Others LGTM |
|
Once recent optimization are done, we should add document about how to set up load balancer in the main doc, and provide it(next release) as activated component in the showcase. |
Just a reminder, satellite is not mandatory so we won't make all agent services connect to it in showcase, as we have 2 Java services (gateway and songs) we can make one of them send data to satellite and leave all others as is. |
With time, more and more verification, could come from the product env(end users), if all are good, I would like to put it as recommended. In all these days perf testing and load balance testing, connection based load balance has very clear disadvantage, but most proxies are only supporting this way. |
We could recommend, but showcase repo serves as a demonstration that will be referenced by all users, we should have examples without Satellite, unless we say officially SkyWalking cannot work without Satellite, which is obviously not the case. I know Satellite can work with or without Kubernetes but for traditional deployments I don't believe users will deploy another Satellite process along with their application process, in this case they will ask for non-Satellite solution. That's why I want to keep agents without Satellite in showcase. |
|
If you are concern about this, I would prefer not deploy satellite in showcase. If you set the principle of deploying XYZ in showcase as tech level mandatory, then let's leave satellite out of it. It is definitely not. Half through satellite, and half using direct link, are really not a good showcase at all. It just increases the confusion, I am afraid. |
Hey that's not what I mean, we have agent services and agentless services and agent is not mandatory tech in SkyWalking but we deploy them still. (I just want to cover more general scenarios that users have). Let's find another way to add Satellite into showcase. Now we have many feature flags that users can choose to deploy a subset of features of SkyWalking(though we enable all features by default), let's add another feature flag |
|
I don't want showcase becomes another challenge to new users. Features related are complex enough so far. |
|
Let's continue discussion on that new created issue if needed. |