Skip to content

Add changelog for 0.5.0 #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 24, 2020
Merged

Add changelog for 0.5.0 #107

merged 1 commit into from
Dec 24, 2020

Conversation

@kezhenxu94
Copy link
Member

@kezhenxu94 kezhenxu94 commented Dec 24, 2020

No description provided.

@kezhenxu94 kezhenxu94 added documentation Improvements or additions to documentation chore Project chores labels Dec 24, 2020
@kezhenxu94 kezhenxu94 added this to the 0.5.0 milestone Dec 24, 2020
@kezhenxu94 kezhenxu94 requested a review from a team December 24, 2020 01:01
kezhenxu94
kezhenxu94 commented Dec 24, 2020
View reviewed changes
.asf.yaml
Comment on lines -38 to -40
required_pull_request_reviews:
dismiss_stale_reviews: true
required_approving_review_count: 1
Copy link
Member Author

@kezhenxu94 kezhenxu94 Dec 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm removing this since trivial changes like this PR can be merged quickly as long as the checks passed

Copy link
Member

@fgksgf fgksgf Dec 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about non-trivial changes ?

Copy link
Member Author

@kezhenxu94 kezhenxu94 Dec 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about non-trivial changes ?

Committers can request reviews from other committers, as we have limited committers in this repo, I'd rather work on trust that we know the changes are non-trivial and need review

Copy link
Member

@fgksgf fgksgf Dec 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can those people who are not members (committer/PMC) merge directly when the checks passed ? If they can't I think this change of .asf.yml is ok.

Copy link
Member Author

@kezhenxu94 kezhenxu94 Dec 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can those people who are not members (committer/PMC) merge directly when the checks passed ? If they can't I think this change of .asf.yml is ok.

Of course they can't, merging needs write access to the repo

Copy link
Member

@fgksgf fgksgf Dec 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I have no worries.

@kezhenxu94 kezhenxu94 merged commit 4a8ea27 into master Dec 24, 2020
@kezhenxu94 kezhenxu94 deleted the rel/0.5.0 branch December 24, 2020 01:41
@kezhenxu94 kezhenxu94 mentioned this pull request Dec 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fgksgf fgksgf fgksgf approved these changes

Assignees

No one assigned

Labels

chore Project chores documentation Improvements or additions to documentation

Projects

None yet

Milestone

0.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@kezhenxu94 @fgksgf