Skip to content

Conversation

@TQJADE
Copy link
Contributor

@TQJADE TQJADE commented Sep 30, 2024

What changes were proposed in this pull request?

Add the required fields for sparkApplicationSentinel

Why are the changes needed?

Without this, when enable sparkApplicationSentinel, the operator got ERROR

Caused by: io.fabric8.kubernetes.client.KubernetesClientException: Failure executing: PUT at: [https://10.96.0.1:443/apis/spark.apache.org/v1alpha1/namespaces/spark-4/sparkapplications/spark-app-sentinel](https://10.96.0.1/apis/spark.apache.org/v1alpha1/namespaces/spark-4/sparkapplications/spark-app-sentinel). Message: SparkApplication.spark.apache.org "spark-app-sentinel" is invalid: spec.runtimeVersions: Required value. Received status: Status(apiVersion=v1, code=422, details=StatusDetails(causes=[StatusCause(field=spec.runtimeVersions, message=Required value, reason=FieldValueRequired, additionalProperties={})], group=spark.apache.org, kind=SparkApplication, name=spark-app-sentinel, retryAfterSeconds=null, uid=null, additionalProperties={}), kind=Status, message=SparkApplication.spark.apache.org "spark-app-sentinel" is invalid: spec.runtimeVersions: Required value, metadata=ListMeta(_continue=null, remainingItemCount=null, resourceVersion=null, selfLink=null, additionalProperties={}), reason=Invalid, status=Failure, additionalProperties={}).

Does this PR introduce any user-facing change?

no

How was this patch tested?

test locally, modify the values.yaml with sparkApplicationSentinel enabled

Was this patch authored or co-authored using generative AI tooling?

no

@github-actions github-actions bot added the BUILD label Sep 30, 2024
@TQJADE TQJADE changed the title Add required fields for sparkApplicationSentinel [SPARK-49830] Add required fields for sparkApplicationSentinel Sep 30, 2024
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM (Pending CIs).
Thank you, @TQJADE .

@dongjoon-hyun
Copy link
Member

Merged to master.

@TQJADE TQJADE deleted the sentinel-check branch September 30, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants