Skip to content

[SPARK-52137] Upgrade pmd to 7.13.0 #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 1 commit into from
Closed

[SPARK-52137] Upgrade pmd to 7.13.0 #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions build-tools/docs-utils/src/main/java/org/apache/spark/k8s/operator/utils/DocTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,7 @@ public void flush(PrintWriter writer) {
private String joinRow(List<String> elements) {
StringBuilder stringBuilder = new StringBuilder(ROW_SEPARATOR);
for (String element : elements) {
stringBuilder.append(element);
stringBuilder.append(ROW_SEPARATOR);
stringBuilder.append(element).append(ROW_SEPARATOR);
Copy link
Member Author

@dongjoon-hyun dongjoon-hyun May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fixed because there is only one instance.

}
if (elements.size() < columns) {
// Append empty cells to end if needed
Expand Down
19 changes: 17 additions & 2 deletions config/pmd/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,13 @@
Apache Spark Kubernetes Operator Ruleset
</description>
<rule ref="category/java/bestpractices.xml">
<exclude name="JUnitAssertionsShouldIncludeMessage" />
<exclude name="JUnitTestContainsTooManyAsserts" />
<exclude name="GuardLogStatement" />
<exclude name="ImplicitFunctionalInterface" />
<exclude name="UnitTestAssertionsShouldIncludeMessage" />
<exclude name="UnitTestContainsTooManyAsserts" />
<exclude name="UnitTestShouldIncludeAssert" />
<exclude name="UnusedLocalVariable" />
<exclude name="LooseCoupling" />
</rule>
<rule ref="category/java/codestyle.xml">
<exclude name="AtLeastOneConstructor" />
Expand All @@ -36,16 +41,24 @@
<exclude name="OnlyOneReturn" />
<exclude name="ShortVariable" />
<exclude name="TooManyStaticImports" />
<exclude name="UnnecessaryCast" />
<exclude name="UnnecessaryFullyQualifiedName" />
<exclude name="UseExplicitTypes" />
<exclude name="UseUnderscoresInNumericLiterals" />
</rule>
<rule ref="category/java/design.xml">
<exclude name="AbstractClassWithoutAnyMethod" />
<exclude name="AvoidCatchingGenericException" />
<exclude name="ClassWithOnlyPrivateConstructorsShouldBeFinal" />
<exclude name="CognitiveComplexity" />
<exclude name="CouplingBetweenObjects" />
<exclude name="CyclomaticComplexity" />
<exclude name="DataClass" />
<exclude name="ExcessiveImports" />
<exclude name="FinalFieldCouldBeStatic" />
<exclude name="LawOfDemeter" />
<exclude name="NPathComplexity" />
<exclude name="SimplifyBooleanReturns" />
<exclude name="TooManyMethods" />
</rule>
<rule ref="category/java/documentation.xml">
Expand All @@ -67,13 +80,15 @@
<exclude name="UseProperClassLoader" />
</rule>
<rule ref="category/java/multithreading.xml">
<exclude name="AvoidSynchronizedStatement" />
<exclude name="DoNotUseThreads" />
<exclude name="UseConcurrentHashMap" />
</rule>
<rule ref="category/java/performance.xml">
<exclude name="AvoidFileStream" />
<exclude name="AvoidInstantiatingObjectsInLoops" />
<exclude name="RedundantFieldInitializer" />
<exclude name="UseArraysAsList" />
</rule>
<rule ref="category/java/security.xml"/>
<!-- exclude on generated files -->
Expand Down
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ mockito = "5.17.0"

# Build Analysis
checkstyle = "10.23.1"
pmd = "6.55.0"
pmd = "7.13.0"
spotbugs-tool = "4.8.6"
spotbugs-plugin = "6.0.17"
spotless-plugin = "6.25.0"
Expand Down
Loading