Skip to content

[SPARK-52647] Fix jvmArgs to support multiple arguments #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-52647] Fix jvmArgs to support multiple arguments #267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build-tools/docker/docker-entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ if [ "$1" = "help" ]; then
elif [ "$1" = "operator" ]; then
echo "Starting Operator..."

exec java -cp "./$SPARK_OPERATOR_JAR" "$LOG_CONFIG" "$OPERATOR_JAVA_OPTS" org.apache.spark.k8s.operator.SparkOperator
exec java -cp "./$SPARK_OPERATOR_JAR" "$LOG_CONFIG" $OPERATOR_JAVA_OPTS org.apache.spark.k8s.operator.SparkOperator
Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous syntax cannot handle multiple Java options.

$ cat test.sh
OPERATOR_JAVA_OPTS="-Dfile.encoding=UTF8 -XX:+ExitOnOutOfMemoryError"
exec java "$OPERATOR_JAVA_OPTS" -XX:+PrintFlagsFinal -version

$ sh test.sh | grep ExitOnOutOfMemoryError
     bool ExitOnOutOfMemoryError                   = false                                     {product} {default}
openjdk version "21.0.7" 2025-04-15
OpenJDK Runtime Environment Homebrew (build 21.0.7)
OpenJDK 64-Bit Server VM Homebrew (build 21.0.7, mixed mode, sharing)

fi

args=("${args[@]}")
Expand Down
Loading