[SPARK-20716][SS] StateStore.abort() should not throw exceptions #17958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #76845 has finished for PR 17958 at commit
|
|
Test build #76844 has finished for PR 17958 at commit
|
|
Test build #3711 has finished for PR 17958 at commit
|
marmbrus
reviewed
May 12, 2017
| if (tempDeltaFile != null) { | ||
| fs.delete(tempDeltaFile, true) | ||
| case e: Exception => | ||
| logWarning(s"Error aborting version $newVersion into $this") |
zsxwing
reviewed
May 12, 2017
| fs.delete(tempDeltaFile, true) | ||
| } | ||
| } catch { | ||
| case c: ClosedChannelException => |
There was a problem hiding this comment.
Why need two cases? The error message is same, and the exception is also in the log.
There was a problem hiding this comment.
Its debug though for the expected case.
There was a problem hiding this comment.
Maybe it should be a warning? In this case, the task will fail and it hurts nothing to output a warning but will be helpful when we have other issues.
|
Test build #76880 has finished for PR 17958 at commit
|
|
LGTM. Merging to master and 2.2. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
May 15, 2017
## What changes were proposed in this pull request? StateStore.abort() should do a best effort attempt to clean up temporary resources. It should not throw errors, especially because its called in a TaskCompletionListener, because this error could hide previous real errors in the task. ## How was this patch tested? No unit test. Author: Tathagata Das <tathagata.das1565@gmail.com> Closes #17958 from tdas/SPARK-20716. (cherry picked from commit 271175e) Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
May 19, 2017
## What changes were proposed in this pull request? StateStore.abort() should do a best effort attempt to clean up temporary resources. It should not throw errors, especially because its called in a TaskCompletionListener, because this error could hide previous real errors in the task. ## How was this patch tested? No unit test. Author: Tathagata Das <tathagata.das1565@gmail.com> Closes apache#17958 from tdas/SPARK-20716.
liyichao
pushed a commit
to liyichao/spark
that referenced
this pull request
May 24, 2017
## What changes were proposed in this pull request? StateStore.abort() should do a best effort attempt to clean up temporary resources. It should not throw errors, especially because its called in a TaskCompletionListener, because this error could hide previous real errors in the task. ## How was this patch tested? No unit test. Author: Tathagata Das <tathagata.das1565@gmail.com> Closes apache#17958 from tdas/SPARK-20716.
cenyuhai
pushed a commit
to cenyuhai/spark
that referenced
this pull request
Oct 8, 2017
## What changes were proposed in this pull request? StateStore.abort() should do a best effort attempt to clean up temporary resources. It should not throw errors, especially because its called in a TaskCompletionListener, because this error could hide previous real errors in the task. ## How was this patch tested? No unit test. Author: Tathagata Das <tathagata.das1565@gmail.com> Closes apache#17958 from tdas/SPARK-20716. (cherry picked from commit 271175e) Signed-off-by: Shixiong Zhu <shixiong@databricks.com> (cherry picked from commit 82ae1f0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
StateStore.abort() should do a best effort attempt to clean up temporary resources. It should not throw errors, especially because its called in a TaskCompletionListener, because this error could hide previous real errors in the task.
How was this patch tested?
No unit test.