Skip to content

[SPARK-20991][SQL] BROADCAST_TIMEOUT conf should be a TimeoutConf #18208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-20991][SQL] BROADCAST_TIMEOUT conf should be a TimeoutConf #18208

wants to merge 1 commit into from

Conversation

liufengdb
Copy link

@liufengdb liufengdb commented Jun 5, 2017 •
edited
Loading

What changes were proposed in this pull request?

The construction of BROADCAST_TIMEOUT conf should take the TimeUnit argument as a TimeoutConf.

@zsxwing
Copy link
Member

zsxwing commented Jun 5, 2017

LGTM. Pending tests.

@liufengdb liufengdb changed the title [SPARK-20991] BROADCAST_TIMEOUT conf should be a TimeoutConf [SQL] BROADCAST_TIMEOUT conf should be a TimeoutConf Jun 5, 2017
@zsxwing
Copy link
Member

zsxwing commented Jun 5, 2017

ok to test

@liufengdb liufengdb changed the title [SQL] BROADCAST_TIMEOUT conf should be a TimeoutConf [SPARK-20991][SQL] BROADCAST_TIMEOUT conf should be a TimeoutConf Jun 5, 2017
@SparkQA
Copy link

SparkQA commented Jun 5, 2017

Test build #77755 has finished for PR 18208 at commit 8a2d37a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member

zsxwing commented Jun 6, 2017

Thanks. Merging to master.

@asfgit asfgit closed this in 88a23d3 Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liufengdb @zsxwing @SparkQA