Skip to content

Conversation

mpetruska
Copy link
Contributor

What changes were proposed in this pull request?

SPARK-20706: Spark-shell not overriding method/variable definition
This is a Scala repl bug ( SI-9740 ), was fixed in version 2.11.9 ( see the original PR )

How was this patch tested?

Added a new test case in ReplSuite.

@srowen
Copy link
Member

srowen commented Dec 4, 2017

OK, so another back-port to fix the 2.11 REPL, which should be resolved in 2.12 anyway?

@SparkQA
Copy link

SparkQA commented Dec 4, 2017

Test build #4003 has finished for PR 19879 at commit f265daa.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mpetruska
Copy link
Contributor Author

This one has a "Major" priority; but otherwise yes, it should be resolved in Scala 2.12 version.

@mpetruska
Copy link
Contributor Author

By the way, are these contributions valuable, or should the focus be 2.12?

@srowen
Copy link
Member

srowen commented Dec 4, 2017

Yes, I think it's reasonable to pull these fixes forward to patch medium-sized problems. We don't have 2.12 support fully working yet, even, so punting the solution to 2.12 means punting to 3.0, probably, and that's still ~6 months off. Meanwhile 2.3 is imminent.

@mpetruska
Copy link
Contributor Author

Fixed the style check problems of the documentation comments. Unfortunately I did not find a way to make Jenkins re-run the tests.

@srowen
Copy link
Member

srowen commented Dec 5, 2017

Jenkins add to whitelist

@SparkQA
Copy link

SparkQA commented Dec 5, 2017

Test build #4004 has finished for PR 19879 at commit db6967c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 5, 2017

Test build #84493 has finished for PR 19879 at commit db6967c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Dec 6, 2017

Merged to master

@asfgit asfgit closed this in 59aa3d5 Dec 6, 2017
@mpetruska mpetruska deleted the SPARK-20706 branch December 6, 2017 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants