-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-25385][BUILD] Upgrade Hadoop 3.1 jackson version to 2.7.8 #22372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test build #95846 has finished for PR 22372 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, changes are only for 3.1 profile
do we have jenkins tests for 3.1 profile? |
We do not have jenkins tests for 3.1 profile: Lines 307 to 310 in 395860a
|
@wangyum, are you doubly sure if SBT picks up the same Jackson? I roughly tried this a bit of while ago and found SBT doesn't pick up Maven's IIRC. |
Also, IIRC, #21596 change is needed for this Jackson upgrade. |
Also, I think we should fix #21588 first. |
<curator.version>2.12.0</curator.version> | ||
<zookeeper.version>3.4.9</zookeeper.version> | ||
<fasterxml.jackson.version>2.7.8</fasterxml.jackson.version> | ||
<fasterxml.jackson.databind.version>2.7.8</fasterxml.jackson.databind.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please test and check SBT's dependency tree as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jackson version below 2.9.5 has CVE issues, I would suggest to upgrade to 2.9.6 as #21596 did. |
I did a simple test for 2.9.6. It works well. But that pr for 3.0. It means that a simple test on branch 2.4 will fail: scala> spark.range(10).write.parquet("/tmp/spark/parquet")
com.fasterxml.jackson.databind.JsonMappingException: Incompatible Jackson version: 2.7.8
at com.fasterxml.jackson.module.scala.JacksonModule$class.setupModule(JacksonModule.scala:64)
at com.fasterxml.jackson.module.scala.DefaultScalaModule.setupModule(DefaultScalaModule.scala:19)
at com.fasterxml.jackson.databind.ObjectMapper.registerModule(ObjectMapper.java:730)
at org.apache.spark.rdd.RDDOperationScope$.<init>(RDDOperationScope.scala:82)
at org.apache.spark.rdd.RDDOperationScope$.<clinit>(RDDOperationScope.scala) How about merge this pr to branch-2.4 only? |
Do we officially support hadoop3 in branch 2.4? If branch 2.4 doesn't target to support Hadoop3 and this fix is only for Hadoop3, then I don't think it is meaningful to have this fix. |
Btw, I don't think we can run current Spark with Hadoop 3.1 without any change. |
What changes were proposed in this pull request?
Upgrade Hadoop 3.1 jackson version to 2.7.8 to fix
JsonMappingException: Incompatible Jackson version: 2.7.8
as Hadoop 3.1 using 2.7.8: https://github.com/apache/hadoop/blob/release-3.1.0-RC1/hadoop-project/pom.xml#L72 .How was this patch tested?
manual tests: