[SPARK-22465][CORE][FOLLOWUP]Use existing partitioner when defaultNumPartitions is equal to maxPartitioner.numPartitions #23581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @cloud-fan @jiangxb1987 @mridulm @sujithjay . Please take a look, thanks :) |
Ngone51
changed the title
|
kindly ping |
|
ok to test |
|
Test build #101482 has finished for PR 23581 at commit
|
|
retest this please. |
cloud-fan
reviewed
Jan 22, 2019
| } | ||
|
|
||
| // If the existing max partitioner is an eligible one, or its partitions number is larger | ||
| // than the default number of partitions, use the existing partitioner. |
There was a problem hiding this comment.
shall we update the comment?
|
retest this please |
|
Test build #101505 has finished for PR 23581 at commit
|
|
Test build #101507 has finished for PR 23581 at commit
|
srowen
approved these changes
Jan 22, 2019
|
thanks, merging to master! |
|
Thanks @cloud-fan @srowen ! |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…mPartitions is equal to maxPartitioner.numPartitions ## What changes were proposed in this pull request? Followup of apache#20091. We could also use existing partitioner when defaultNumPartitions is equal to the maxPartitioner's numPartitions. ## How was this patch tested? Existed. Closes apache#23581 from Ngone51/dev-use-existing-partitioner-when-defaultNumPartitions-equalTo-MaxPartitioner#-numPartitions. Authored-by: Ngone51 <ngone_5451@163.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Followup of #20091. We could also use existing partitioner when defaultNumPartitions is equal to the maxPartitioner's numPartitions.
How was this patch tested?
Existed.