Skip to content

[SPARK-26694][CORE] Progress bar should be enabled by default for spark-shell #23618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[SPARK-26694][CORE] Progress bar should be enabled by default for spark-shell #23618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a66db05
[SPARK-26694][CORE] Progress bar should be enabled by default for spa…
ankuriitg Jan 22, 2019
b88089d
Updated the unit test case to ensure ConsoleProgressBar is visible wi…
ankuriitg Jan 23, 2019
e454b5a
Review comments: Part 1
ankuriitg Jan 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/scala/org/apache/spark/SparkContext.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ class SparkContext(config: SparkConf) extends Logging {
_statusTracker = new SparkStatusTracker(this, _statusStore)

_progressBar =
if (_conf.get(UI_SHOW_CONSOLE_PROGRESS) && !log.isInfoEnabled) {
if (_conf.get(UI_SHOW_CONSOLE_PROGRESS)) {
Some(new ConsoleProgressBar(this))
} else {
None
Expand Down
18 changes: 18 additions & 0 deletions core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,11 +479,29 @@ class SparkSubmitSuite
val appArgs1 = new SparkSubmitArguments(clArgs1)
val (_, _, conf1, _) = submit.prepareSubmitEnvironment(appArgs1)
conf1.get(UI_SHOW_CONSOLE_PROGRESS) should be (true)
var sc1: SparkContext = null
try {
sc1 = new SparkContext(conf1)
assert(sc1.progressBar.isDefined)
} finally {
if (sc1 != null) {
sc1.stop()
}
}

val clArgs2 = Seq("--class", "org.SomeClass", "thejar.jar")
val appArgs2 = new SparkSubmitArguments(clArgs2)
val (_, _, conf2, _) = submit.prepareSubmitEnvironment(appArgs2)
assert(!conf2.contains(UI_SHOW_CONSOLE_PROGRESS))
var sc2: SparkContext = null
try {
sc2 = new SparkContext(conf2)
assert(!sc2.progressBar.isDefined)
} finally {
if (sc2 != null) {
sc2.stop()
}
}
}

test("launch simple application with spark-submit") {
Expand Down