-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-27563][FOLLOWUP] Fix to download new release from dist.apache.org
#24544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #105209 has finished for PR 24544 at commit
|
|
I want to know how the previous version of spark was downloaded to |
| import scala.io.Source | ||
| try { | ||
| Source.fromURL("https://dist.apache.org/repos/dist/release/spark/").mkString | ||
| Source.fromURL(s"${releaseMirror}/spark").mkString |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe $releaseMirror is better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're picking nits and you change it again, it's not really a mirror. It's the primary dist server. asfDist or something.
|
Test build #105210 has finished for PR 24544 at commit
|
|
Wouldn't it be uploaded soon? |
|
Test build #105211 has finished for PR 24544 at commit
|
Maybe @cloud-fan knows, but we can avoid this error in the next release. |
|
After uploading, it takes a while for the resources to be available in the Mirror Network. This means the PR builder will be broken for a while. This fix LGTM |
dist.apache.org
| import scala.io.Source | ||
| try { | ||
| Source.fromURL("https://dist.apache.org/repos/dist/release/spark/").mkString | ||
| Source.fromURL(s"${releaseMirror}/spark").mkString |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're picking nits and you change it again, it's not really a mirror. It's the primary dist server. asfDist or something.
dist.apache.orgdist.apache.org
|
I removed |
|
Merged to master |
What changes were proposed in this pull request?
https://archive.apache.org/dist/spark/does not have latest Spark 2.4.3:This pr add
https://dist.apache.org/repos/dist/release/spark/to mirrors list to download latest Spark.https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/105202/testReport/org.apache.spark.sql.hive/HiveExternalCatalogVersionsSuite/_It_is_not_a_test_it_is_a_sbt_testing_SuiteSelector_/
How was this patch tested?
manual tests: