Skip to content

Conversation

@wangyum
Copy link
Member

@wangyum wangyum commented May 7, 2019

What changes were proposed in this pull request?

https://archive.apache.org/dist/spark/ does not have latest Spark 2.4.3:

This pr add https://dist.apache.org/repos/dist/release/spark/ to mirrors list to download latest Spark.

https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/105202/testReport/org.apache.spark.sql.hive/HiveExternalCatalogVersionsSuite/_It_is_not_a_test_it_is_a_sbt_testing_SuiteSelector_/

How was this patch tested?

manual tests:

build/sbt "hive/testOnly *.HiveExternalCatalogVersionsSuite"  -Phive

@SparkQA
Copy link

SparkQA commented May 7, 2019

Test build #105209 has finished for PR 24544 at commit bfb251b.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@beliefer
Copy link
Contributor

beliefer commented May 7, 2019

I want to know how the previous version of spark was downloaded to https://archive.apache.org/dist/spark/.

import scala.io.Source
try {
Source.fromURL("https://dist.apache.org/repos/dist/release/spark/").mkString
Source.fromURL(s"${releaseMirror}/spark").mkString
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe $releaseMirror is better.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're picking nits and you change it again, it's not really a mirror. It's the primary dist server. asfDist or something.

@SparkQA
Copy link

SparkQA commented May 7, 2019

Test build #105210 has finished for PR 24544 at commit 5e09e5b.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Wouldn't it be uploaded soon?

@SparkQA
Copy link

SparkQA commented May 7, 2019

Test build #105211 has finished for PR 24544 at commit cf946e7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangyum
Copy link
Member Author

wangyum commented May 7, 2019

Wouldn't it be uploaded soon?

Maybe @cloud-fan knows, but we can avoid this error in the next release.

@cloud-fan
Copy link
Contributor

After uploading, it takes a while for the resources to be available in the Mirror Network. This means the PR builder will be broken for a while.

This fix LGTM

@dongjoon-hyun dongjoon-hyun changed the title [HOT-FIX] Unable to download Spark 2.4.3 [SPARK-27563][FOLLOWUP][HOTFIX] Fix to download new release from dist.apache.org May 7, 2019
import scala.io.Source
try {
Source.fromURL("https://dist.apache.org/repos/dist/release/spark/").mkString
Source.fromURL(s"${releaseMirror}/spark").mkString
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're picking nits and you change it again, it's not really a mirror. It's the primary dist server. asfDist or something.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-27563][FOLLOWUP][HOTFIX] Fix to download new release from dist.apache.org [SPARK-27563][FOLLOWUP] Fix to download new release from dist.apache.org May 7, 2019
@dongjoon-hyun
Copy link
Member

I removed [HOTFIX] from the title because it starts to pass. (#24516)

@srowen
Copy link
Member

srowen commented May 9, 2019

Merged to master

@srowen srowen closed this in b5ffec1 May 9, 2019
@wangyum wangyum deleted the Unable-to-download-Spark-2.4.3 branch June 10, 2019 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants