Skip to content

[SPARK-28834][SQL] Support sessionInitStatement in dataframe jdbc write path #26100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yaooqinn wants to merge 2 commits into from
Closed

[SPARK-28834][SQL] Support sessionInitStatement in dataframe jdbc write path #26100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46e9081
[SPARK-28834][SQL] Support sessionInitStatement in dataframe write path
yaooqinn Oct 12, 2019
828d1ee
it
yaooqinn Oct 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...r-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,4 +513,14 @@ class OracleIntegrationSuite extends DockerJDBCIntegrationSuite with SharedSpark
""".stripMargin.replaceAll("\n", " "))
assert(sql("select id, d, t from queryOption").collect.toSet == expectedResult)
}

test("sessionInitStatement for write path") {
val df1 = sparkContext.parallelize(Seq(("foo"))).toDF("x")
val tableName = "SPARK-28834"
val writeProps = new Properties()
writeProps.setProperty("sessionInitStatement",
"CREATE TABLE IF NOT EXISTS " + tableName + " (id number(10) NOT NULL)")
df1.write.jdbc(jdbcUrl, tableName + "op", writeProps)
assert(spark.read.jdbc(jdbcUrl, tableName, new Properties()).collect().isEmpty)
}
}
11 changes: 11 additions & 0 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,6 +619,17 @@ object JdbcUtils extends Logging {
val conn = getConnection()
var committed = false

options.sessionInitStatement.foreach { sql =>
val statement = conn.prepareStatement(sql)
logInfo(s"Executing sessionInitStatement: $sql")
try {
statement.setQueryTimeout(options.queryTimeout)
statement.execute()
} finally {
statement.close()
}
}

var finalIsolationLevel = Connection.TRANSACTION_NONE
if (isolationLevel != Connection.TRANSACTION_NONE) {
try {
Expand Down