Skip to content

Conversation

@ulysses-you
Copy link
Contributor

@ulysses-you ulysses-you commented Apr 19, 2021

What changes were proposed in this pull request?

Revise the outputPartitioning number in some SparkPlan

  • UnionExec
  • RowDataSourceScanExec
  • LogicalRDD
  • RDDScanExec
  • ExternalRDDScanExec
  • LocalTableScanExec
  • ExpandExec
  • BroadcastNestedLoopJoinExec
  • CoGroupExec
  • DataSourceV2ScanExecBase
  • CustomShuffleReaderExec

The mian change follow the logical

  1. if rdd is known, using rdd.partitions.length
  2. using child.outputPartitioning.numPartitions
  3. check SinglePartition

Why are the changes needed?

Make outputPartitioning more reasonable.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass CI.

@github-actions github-actions bot added the SQL label Apr 19, 2021
@SparkQA
Copy link

SparkQA commented Apr 19, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42161/

@SparkQA
Copy link

SparkQA commented Apr 19, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42161/

@SparkQA
Copy link

SparkQA commented Apr 19, 2021

Test build #137630 has finished for PR 32236 at commit 6efe5fa.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@ulysses-you ulysses-you changed the title [SPARK-35137][SQL] Revise outputpartitioning number in some SparkPlan [WIP][SPARK-35137][SQL] Revise outputpartitioning number in some SparkPlan Apr 20, 2021
@SparkQA
Copy link

SparkQA commented Apr 23, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42385/

@SparkQA
Copy link

SparkQA commented Apr 23, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42385/

@SparkQA
Copy link

SparkQA commented Apr 23, 2021

Test build #137855 has finished for PR 32236 at commit 4fd5111.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

val df3 = Seq(1 -> "a").toDF("i", "j").orderBy($"i")
val df4 = Seq(1 -> "a").toDF("i", "j").orderBy($"i")
val df3 = Seq(1 -> "a", 2 -> "b").toDF("i", "j").orderBy($"i")
val df4 = Seq(1 -> "a", 2 -> "b").toDF("i", "j").orderBy($"i")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seq(1 -> "a").toDF("i", "j") output partitioning number is 1 so it's SinglePartition.

@ulysses-you ulysses-you changed the title [WIP][SPARK-35137][SQL] Revise outputpartitioning number in some SparkPlan [WIP][SPARK-35137][SQL] Revise outputpartitioning in some SparkPlan Apr 25, 2021
@SparkQA
Copy link

SparkQA commented Apr 25, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42424/

@SparkQA
Copy link

SparkQA commented Apr 25, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42424/

@SparkQA
Copy link

SparkQA commented Apr 25, 2021

Test build #137899 has finished for PR 32236 at commit e104a30.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 29, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42589/

@SparkQA
Copy link

SparkQA commented May 21, 2021

Test build #138777 has finished for PR 32236 at commit a33157b.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 21, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43301/

@github-actions
Copy link

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Aug 30, 2021
@github-actions github-actions bot closed this Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants