Skip to content

Conversation

williamhyun
Copy link
Member

What changes were proposed in this pull request?

This PR aims to make run_scala_tests respect test module order

Why are the changes needed?

Currently the execution order is random.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Manually through the following and check if the catalyst module runs first.

$ SKIP_MIMA=1 SKIP_UNIDOC=1 ./dev/run-tests --parallelism 1 --modules "catalyst,hive-thriftserver"

@github-actions github-actions bot added the BUILD label Nov 14, 2021
@SparkQA
Copy link

SparkQA commented Nov 14, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49678/

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @williamhyun .
I checked this PR changed the execution order.

Merged to master/3.2/3.1.

dongjoon-hyun pushed a commit that referenced this pull request Nov 14, 2021
### What changes were proposed in this pull request?
This PR aims to make `run_scala_tests` respect test module order

### Why are the changes needed?
Currently the execution order is random.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Manually through the following and check if the catalyst module runs first.

```
$ SKIP_MIMA=1 SKIP_UNIDOC=1 ./dev/run-tests --parallelism 1 --modules "catalyst,hive-thriftserver"
```

Closes #34590 from williamhyun/order.

Authored-by: William Hyun <william@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit c2221a8)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun pushed a commit that referenced this pull request Nov 14, 2021
### What changes were proposed in this pull request?
This PR aims to make `run_scala_tests` respect test module order

### Why are the changes needed?
Currently the execution order is random.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Manually through the following and check if the catalyst module runs first.

```
$ SKIP_MIMA=1 SKIP_UNIDOC=1 ./dev/run-tests --parallelism 1 --modules "catalyst,hive-thriftserver"
```

Closes #34590 from williamhyun/order.

Authored-by: William Hyun <william@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit c2221a8)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@SparkQA
Copy link

SparkQA commented Nov 14, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49678/

@SparkQA
Copy link

SparkQA commented Nov 14, 2021

Test build #145209 has finished for PR 34590 at commit d78eb12.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

sunchao pushed a commit to sunchao/spark that referenced this pull request Dec 8, 2021
### What changes were proposed in this pull request?
This PR aims to make `run_scala_tests` respect test module order

### Why are the changes needed?
Currently the execution order is random.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Manually through the following and check if the catalyst module runs first.

```
$ SKIP_MIMA=1 SKIP_UNIDOC=1 ./dev/run-tests --parallelism 1 --modules "catalyst,hive-thriftserver"
```

Closes apache#34590 from williamhyun/order.

Authored-by: William Hyun <william@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit c2221a8)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
catalinii pushed a commit to lyft/spark that referenced this pull request Feb 22, 2022
### What changes were proposed in this pull request?
This PR aims to make `run_scala_tests` respect test module order

### Why are the changes needed?
Currently the execution order is random.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Manually through the following and check if the catalyst module runs first.

```
$ SKIP_MIMA=1 SKIP_UNIDOC=1 ./dev/run-tests --parallelism 1 --modules "catalyst,hive-thriftserver"
```

Closes apache#34590 from williamhyun/order.

Authored-by: William Hyun <william@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit c2221a8)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
catalinii pushed a commit to lyft/spark that referenced this pull request Mar 4, 2022
### What changes were proposed in this pull request?
This PR aims to make `run_scala_tests` respect test module order

### Why are the changes needed?
Currently the execution order is random.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Manually through the following and check if the catalyst module runs first.

```
$ SKIP_MIMA=1 SKIP_UNIDOC=1 ./dev/run-tests --parallelism 1 --modules "catalyst,hive-thriftserver"
```

Closes apache#34590 from williamhyun/order.

Authored-by: William Hyun <william@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit c2221a8)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants