[SPARK-38825][SQL][TEST] Add a test to cover parquet notIn filter #36109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| test("in and notIn filters") { |
There was a problem hiding this comment.
Please add a test prefix, SPARK-38825: .
dongjoon-hyun
approved these changes
Apr 7, 2022
viirya
approved these changes
Apr 7, 2022
viirya
changed the title
sunchao
approved these changes
Apr 7, 2022
|
I have tested this manually. I will merge this without pending CI. |
huaxingao
added a commit
that referenced
this pull request
Apr 7, 2022
### What changes were proposed in this pull request? Currently we don't have a test for parquet `notIn` filter, so add a test for this ### Why are the changes needed? to make tests more complete ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? new test Closes #36109 from huaxingao/inFilter. Authored-by: huaxingao <huaxin_gao@apple.com> Signed-off-by: huaxingao <huaxin_gao@apple.com> (cherry picked from commit d6fd040) Signed-off-by: huaxingao <huaxin_gao@apple.com>
|
Merged to master/3.3. Thank you all! |
kazuyukitanimura
pushed a commit
to kazuyukitanimura/spark
that referenced
this pull request
Aug 10, 2022
Currently we don't have a test for parquet `notIn` filter, so add a test for this to make tests more complete no new test Closes apache#36109 from huaxingao/inFilter. Authored-by: huaxingao <huaxin_gao@apple.com> Signed-off-by: huaxingao <huaxin_gao@apple.com> (cherry picked from commit d6fd040) Signed-off-by: huaxingao <huaxin_gao@apple.com> (cherry picked from commit cf7e357)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently we don't have a test for parquet
notInfilter, so add a test for thisWhy are the changes needed?
to make tests more complete
Does this PR introduce any user-facing change?
no
How was this patch tested?
new test