Skip to content

Conversation

@beryllw
Copy link

@beryllw beryllw commented Sep 20, 2022

What changes were proposed in this pull request?

This PR removes application name in spark streaming metrics name.
Spark StreamingSource Metrics sourceName is inappropriate.The label now looks like application_xxxxx_xxxx_driver_NetworkWordCount_StreamingMetrics_streaming_lastCompletedBatch_processingEndTime , instead of application_xxxxx_xxxx_driver_StreamingMetrics_streaming_lastCompletedBatch_processingEndTime, the Spark app name is not need.
This makes it hard to use metrics for different Spark applications over time. And this makes the metrics sourceName standard inconsistent

Why are the changes needed?

Removing the application name in spark streaming metrics name is consistent with the metrics name for the other metrics namespace.

Does this PR introduce any user-facing change?

No

How was this patch tested?

N/A

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@beryllw
Copy link
Author

beryllw commented Sep 21, 2022

Hi, @HeartSaVioR could you please take a look whenever you have a chance? Thanks!

@beryllw beryllw closed this Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants