[SPARK-45665][INFRA] Uses different ORACLE_DOCKER_IMAGE_NAME in the scheduled builds in other branches
#43496
Conversation
LuciferYang
changed the title
ORACLE_DOCKER_IMAGE_NAME in the scheduled builds in other branchesORACLE_DOCKER_IMAGE_NAME in the scheduled builds in other branches
| "SCALA_PROFILE": "scala2.13", | ||
| "PYTHON_TO_TEST": "" | ||
| "PYTHON_TO_TEST": "", | ||
| "ORACLE_DOCKER_IMAGE_NAME": "gvenzl/oracle-xe:21.3.0" |
There was a problem hiding this comment.
The build_and_test.yml in branch-3.3 is configured as oracle-xe:18.4.0, but the previous daily test has always used oracle-xe:21.3.0, so it is still configured as oracle-xe:21.3.0 here.
LuciferYang
changed the title
ORACLE_DOCKER_IMAGE_NAME in the scheduled builds in other branchesORACLE_DOCKER_IMAGE_NAME in the scheduled builds in other branches
|
I've tested this solution in my personal repository, and it should be feasible. branch-3.3: https://github.com/LuciferYang/spark/actions/runs/6643102365/job/18054383056 
branch-3.4: https://github.com/LuciferYang/spark/actions/runs/6637023118 
branch-3.5: https://github.com/LuciferYang/spark/actions/runs/6637015146/job/18065960793 
|
LuciferYang
changed the title
ORACLE_DOCKER_IMAGE_NAME in the scheduled builds in other branchesORACLE_DOCKER_IMAGE_NAME in the scheduled builds in other branches
|
Merged into master. I will keep an eye on tomorrow's daily test. |
|
Thanks @HyukjinKwon ~ |
|
+1, late LGTM. |
|
Thanks @dongjoon-hyun ~ |
|
branch-3.3:https://github.com/apache/spark/actions/runs/6650581612 All passed ~ |
3 participants
What changes were proposed in this pull request?
#43123 upgraded the version of Oracle used for testing. As the daily test will reuse
build_and_test.yml, the branch-3.x will also use the new version. However, due to the lack of synchronized code changes, theOracleIntegrationSuitein theDocker integration testscannot pass the test during the daily test of branch-3.x:So this PR adds the ORACLE_DOCKER_IMAGE_NAME environment variable to the daily test yml file for branch-3.x and uses the previous version of the Oracle Docker image that can pass the test successfully.
Why are the changes needed?
Restore the daily test for branch-3.x.
Does this PR introduce any user-facing change?
No,dev-only
How was this patch tested?
Monitor the daily test results.
Was this patch authored or co-authored using generative AI tooling?
No