[SPARK-50398][CORE] Use ExitCode 0 for --help usage in Spark scripts
#48939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pts consistently
dongjoon-hyun
force-pushed
the
SPARK-50398
branch
from
381fb53 to
ff5b16c
Compare
dongjoon-hyun
commented
Nov 22, 2024
|
|
||
| "${SPARK_HOME}"/bin/spark-class $CLASS --help 2>&1 | grep -v "$pattern" 1>&2 | ||
| exit 1 | ||
| [[ $# -lt 1 ]] && exit 1 || exit 0 |
Member
Author
There was a problem hiding this comment.
Note that,
sbin/start-worker.shwith no argument exits with1in the same way.sbin/start-worker.sh --helpexists with0after this PR.
MaxGekk
approved these changes
Nov 23, 2024
Member
|
+1, LGTM. Merging to master. |
Member
Author
|
Thank you, @MaxGekk . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to use
0as the exit code for--helpusage in Spark scripts consistently to provide better and consistent UX from Apache Spark 4.0.0.Why are the changes needed?
Initially, Apache Spark was designed to exit with
0when--helpis given because--helpargument is not a error case.SparkSubmit
spark/core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala
Lines 458 to 459 in d5da49d
Spark Master
spark/core/src/main/scala/org/apache/spark/deploy/master/MasterArguments.scala
Lines 88 to 89 in d5da49d
Spark Worker
spark/core/src/main/scala/org/apache/spark/deploy/worker/WorkerArguments.scala
Lines 107 to 108 in d5da49d
Spark History Server
spark/core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
Lines 39 to 40 in d5da49d
In addition, all scripts under
bin/*return0consistently like the following. This PR changessbin/*scripts additionally for consistency.Does this PR introduce any user-facing change?
Yes, but this is a exit status code for
--helpor-h.How was this patch tested?
Manual review.
Was this patch authored or co-authored using generative AI tooling?
No.