-
Couldn't load subscription status.
- Fork 28.9k
[MINOR][TESTS] Use SparkContext.setLogLevel in QuietTest #48966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Merged to master. |
|
This may have some negative impacts, as I have noticed some new flaky tests in recent GAs that might be related to this:
Could this pr potentially trigger the aforementioned concurrent exceptions? Do you have time to confirm it? Thanks @HyukjinKwon I have created https://issues.apache.org/jira/browse/SPARK-50434 |
|
let me make a fix |
|
BTW, this PR doesn't trigger the exception. It was already there before so I made this fix and see if it fixes :-). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM.
|
let me revert this - I think it becomes more flaky as @LuciferYang said. I am sorry for back and forth. I am taking a look for a proper fix |
What changes were proposed in this pull request?
This PR proposes to use SparkContext.setLogLevel in QuietTest
Why are the changes needed?
To avoid the direct update of logger but reuses SparkContext.setLogLevel.
Does this PR introduce any user-facing change?
No, test-only.
How was this patch tested?
Manually tested.
Was this patch authored or co-authored using generative AI tooling?
No.