[SPARK-51305][SQL][CONNECT] Improve SparkConnectPlanExecution.createObservedMetricsResponse
#50066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beliefer
force-pushed
the
SPARK-51305
branch
from
6b96031 to
58a8573
Compare
dongjoon-hyun
approved these changes
Feb 24, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @beliefer .
dongjoon-hyun
changed the title
SparkConnectPlanExecution.createObservedMetricsResponse
dongjoon-hyun
pushed a commit
that referenced
this pull request
Feb 24, 2025
…ObservedMetricsResponse` ### What changes were proposed in this pull request? This PR proposes to improve the code for `createObservedMetricsResponse`. ### Why are the changes needed? There exists a duplicate judgement in loop, we should eliminate it. ### Does this PR introduce _any_ user-facing change? 'No'. ### How was this patch tested? GA. ### Was this patch authored or co-authored using generative AI tooling? 'No'. Closes #50066 from beliefer/SPARK-51305. Authored-by: beliefer <beliefer@163.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 9f637b5) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
|
Merged to master/4.0. |
Contributor
Author
|
@dongjoon-hyun Thank you ! |
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
…ObservedMetricsResponse` ### What changes were proposed in this pull request? This PR proposes to improve the code for `createObservedMetricsResponse`. ### Why are the changes needed? There exists a duplicate judgement in loop, we should eliminate it. ### Does this PR introduce _any_ user-facing change? 'No'. ### How was this patch tested? GA. ### Was this patch authored or co-authored using generative AI tooling? 'No'. Closes apache#50066 from beliefer/SPARK-51305. Authored-by: beliefer <beliefer@163.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 6d5b7f3) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to improve the code for
createObservedMetricsResponse.Why are the changes needed?
There exists a duplicate judgement in loop, we should eliminate it.
Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
GA.
Was this patch authored or co-authored using generative AI tooling?
'No'.