[SPARK-50692][SQL][FOLLOWUP] Add the LPAD and RPAD pushdown support for H2 #50068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Feb 24, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @beliefer .
Merged to master for Apache Spark 4.1.0.
dongjoon-hyun
changed the title
Member
|
Oh, did you aim to use this as a follow-up, @beliefer ? |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Feb 24, 2025
### What changes were proposed in this pull request? This PR proposes to add the `LPAD` and `RPAD` pushdown support for H2. ### Why are the changes needed? #49325 added the support for `RPAD` pushdown. H2 as a built-in JDBC dialect for the test purpose, should add the `LPAD` and `RPAD` pushdown support for H2. ### Does this PR introduce _any_ user-facing change? 'Yes'. Spark will supports pushdown for `LPAD` and `RPAD` for H2. ### How was this patch tested? GA> ### Was this patch authored or co-authored using generative AI tooling? 'No'. Closes #50068 from beliefer/SPARK-50692. Authored-by: beliefer <beliefer@163.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit ea15a95) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
|
Please don't forget |
Contributor
Author
Uh, I forgot it. I want it to be a follow-up. |
Contributor
Author
|
@dongjoon-hyun Thank you! |
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
### What changes were proposed in this pull request? This PR proposes to add the `LPAD` and `RPAD` pushdown support for H2. ### Why are the changes needed? apache#49325 added the support for `RPAD` pushdown. H2 as a built-in JDBC dialect for the test purpose, should add the `LPAD` and `RPAD` pushdown support for H2. ### Does this PR introduce _any_ user-facing change? 'Yes'. Spark will supports pushdown for `LPAD` and `RPAD` for H2. ### How was this patch tested? GA> ### Was this patch authored or co-authored using generative AI tooling? 'No'. Closes apache#50068 from beliefer/SPARK-50692. Authored-by: beliefer <beliefer@163.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 6cc7a40) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to add the
LPADandRPADpushdown support for H2.Why are the changes needed?
#49325 added the support for
RPADpushdown.H2 as a built-in JDBC dialect for the test purpose, should add the
LPADandRPADpushdown support for H2.Does this PR introduce any user-facing change?
'Yes'.
Spark will supports pushdown for
LPADandRPADfor H2.How was this patch tested?
GA>
Was this patch authored or co-authored using generative AI tooling?
'No'.