Skip to content

Conversation

@kaka1992
Copy link
Contributor

Add RDD[Row] implicits change to DataFrame and unit test in DataFrameImplicitsSuite test("RDD[Row]").

云峤 added 3 commits March 16, 2015 14:56
… for RDD[Row] and add RDD[Row] test in the DataFrameImplicitsSuite.
… for RDD[Row] and add RDD[Row] test in the DataFrameImplicitsSuite.
… for RDD[Row] and add RDD[Row] test in the DataFrameImplicitsSuite.
@yhuai
Copy link
Contributor

yhuai commented Mar 17, 2015

@kaka1992 Most of the time, the schema of a row will be null (actually, only a GenericRowWithSchema has a schema). So, I think we cannot add this implicit method.

@marmbrus
Copy link
Contributor

ok to test

@marmbrus
Copy link
Contributor

I think I agree with @yhuai. I'm not sure if that test cases is even making the implicit fire.

@marmbrus
Copy link
Contributor

As such I would suggest we close this issue.

@kaka1992
Copy link
Contributor Author

Maybe we can rebuild the schema using the exist row when the it doesn't contain schema data.

@SparkQA
Copy link

SparkQA commented Mar 18, 2015

Test build #28759 has finished for PR 5040 at commit eddd634.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kaka1992
Copy link
Contributor Author

I add some code to fix char support in dataTypes when we want to get char schema info.
[SPARK-6412]

@SparkQA
Copy link

SparkQA commented Mar 19, 2015

Test build #28873 has finished for PR 5040 at commit 73d7773.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Mar 19, 2015

Test build #28874 has finished for PR 5040 at commit a2eaf3d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in 0cc8fcb Apr 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants