[SPARK-51789][CORE][FOLLOW-UP] Set the initial Spark Connect mode properly #50846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
thanks, merging to master/4.0! |
cloud-fan
pushed a commit
that referenced
this pull request
May 9, 2025
…perly ### What changes were proposed in this pull request? This PR is a followup of #50575 that sets the initial Spark Connect mode by reading `SPARK_CONNECT_MODE`. ### Why are the changes needed? In Spark 4.0 release (Spark Connect distribution), ```bash SPARK_CONNECT_MODE=1 ./bin/spark-shell ``` starts Spark Classic shells. ### Does this PR introduce _any_ user-facing change? No to end users because the main change has not been released yet. ### How was this patch tested? Manually tested with some combinations below: ``` SPARK_CONNECT_MODE=1 ./bin/spark-shell SPARK_CONNECT_MODE=1 ./bin/spark-shell --master local SPARK_CONNECT_MODE=1 ./bin/pyspark --conf spark.api.mode=classic --master local SPARK_CONNECT_MODE=1 ./bin/pyspark --master local --conf spark.api.mode=connect SPARK_CONNECT_MODE=1 ./bin/pyspark --conf spark.api.mode=classic SPARK_CONNECT_MODE=1 ./bin/pyspark --conf spark.api.mode=connect SPARK_CONNECT_MODE=1 ./bin/pyspark SPARK_CONNECT_MODE=0 ./bin/spark-shell SPARK_CONNECT_MODE=0 ./bin/spark-shell --master local SPARK_CONNECT_MODE=0 ./bin/pyspark --conf spark.api.mode=classic --master local SPARK_CONNECT_MODE=0 ./bin/pyspark --master local --conf spark.api.mode=connect SPARK_CONNECT_MODE=0 ./bin/pyspark --conf spark.api.mode=classic SPARK_CONNECT_MODE=0 ./bin/pyspark --conf spark.api.mode=connect SPARK_CONNECT_MODE=0 ./bin/pyspark SPARK_CONNECT_MODE=1 ./bin/spark-shell --master "local[*]" --remote "local[*]" SPARK_CONNECT_MODE=1 ./bin/pyspark --conf spark.remote="local[*]" --conf spark.api.mode=connect --conf spark.master="local[*]" SPARK_CONNECT_MODE=1 ./bin/pyspark --master "local[*]" --remote "local[*]" SPARK_CONNECT_MODE=1 ./bin/pyspark --conf spark.remote="local[*]" --conf spark.api.mode=connect --master "local[*]" ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #50846 from HyukjinKwon/SPARK-51789-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 207e296) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
yhuang-db
pushed a commit
to yhuang-db/spark
that referenced
this pull request
Jun 9, 2025
…perly ### What changes were proposed in this pull request? This PR is a followup of apache#50575 that sets the initial Spark Connect mode by reading `SPARK_CONNECT_MODE`. ### Why are the changes needed? In Spark 4.0 release (Spark Connect distribution), ```bash SPARK_CONNECT_MODE=1 ./bin/spark-shell ``` starts Spark Classic shells. ### Does this PR introduce _any_ user-facing change? No to end users because the main change has not been released yet. ### How was this patch tested? Manually tested with some combinations below: ``` SPARK_CONNECT_MODE=1 ./bin/spark-shell SPARK_CONNECT_MODE=1 ./bin/spark-shell --master local SPARK_CONNECT_MODE=1 ./bin/pyspark --conf spark.api.mode=classic --master local SPARK_CONNECT_MODE=1 ./bin/pyspark --master local --conf spark.api.mode=connect SPARK_CONNECT_MODE=1 ./bin/pyspark --conf spark.api.mode=classic SPARK_CONNECT_MODE=1 ./bin/pyspark --conf spark.api.mode=connect SPARK_CONNECT_MODE=1 ./bin/pyspark SPARK_CONNECT_MODE=0 ./bin/spark-shell SPARK_CONNECT_MODE=0 ./bin/spark-shell --master local SPARK_CONNECT_MODE=0 ./bin/pyspark --conf spark.api.mode=classic --master local SPARK_CONNECT_MODE=0 ./bin/pyspark --master local --conf spark.api.mode=connect SPARK_CONNECT_MODE=0 ./bin/pyspark --conf spark.api.mode=classic SPARK_CONNECT_MODE=0 ./bin/pyspark --conf spark.api.mode=connect SPARK_CONNECT_MODE=0 ./bin/pyspark SPARK_CONNECT_MODE=1 ./bin/spark-shell --master "local[*]" --remote "local[*]" SPARK_CONNECT_MODE=1 ./bin/pyspark --conf spark.remote="local[*]" --conf spark.api.mode=connect --conf spark.master="local[*]" SPARK_CONNECT_MODE=1 ./bin/pyspark --master "local[*]" --remote "local[*]" SPARK_CONNECT_MODE=1 ./bin/pyspark --conf spark.remote="local[*]" --conf spark.api.mode=connect --master "local[*]" ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#50846 from HyukjinKwon/SPARK-51789-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
…perly ### What changes were proposed in this pull request? This PR is a followup of apache#50575 that sets the initial Spark Connect mode by reading `SPARK_CONNECT_MODE`. ### Why are the changes needed? In Spark 4.0 release (Spark Connect distribution), ```bash SPARK_CONNECT_MODE=1 ./bin/spark-shell ``` starts Spark Classic shells. ### Does this PR introduce _any_ user-facing change? No to end users because the main change has not been released yet. ### How was this patch tested? Manually tested with some combinations below: ``` SPARK_CONNECT_MODE=1 ./bin/spark-shell SPARK_CONNECT_MODE=1 ./bin/spark-shell --master local SPARK_CONNECT_MODE=1 ./bin/pyspark --conf spark.api.mode=classic --master local SPARK_CONNECT_MODE=1 ./bin/pyspark --master local --conf spark.api.mode=connect SPARK_CONNECT_MODE=1 ./bin/pyspark --conf spark.api.mode=classic SPARK_CONNECT_MODE=1 ./bin/pyspark --conf spark.api.mode=connect SPARK_CONNECT_MODE=1 ./bin/pyspark SPARK_CONNECT_MODE=0 ./bin/spark-shell SPARK_CONNECT_MODE=0 ./bin/spark-shell --master local SPARK_CONNECT_MODE=0 ./bin/pyspark --conf spark.api.mode=classic --master local SPARK_CONNECT_MODE=0 ./bin/pyspark --master local --conf spark.api.mode=connect SPARK_CONNECT_MODE=0 ./bin/pyspark --conf spark.api.mode=classic SPARK_CONNECT_MODE=0 ./bin/pyspark --conf spark.api.mode=connect SPARK_CONNECT_MODE=0 ./bin/pyspark SPARK_CONNECT_MODE=1 ./bin/spark-shell --master "local[*]" --remote "local[*]" SPARK_CONNECT_MODE=1 ./bin/pyspark --conf spark.remote="local[*]" --conf spark.api.mode=connect --conf spark.master="local[*]" SPARK_CONNECT_MODE=1 ./bin/pyspark --master "local[*]" --remote "local[*]" SPARK_CONNECT_MODE=1 ./bin/pyspark --conf spark.remote="local[*]" --conf spark.api.mode=connect --master "local[*]" ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#50846 from HyukjinKwon/SPARK-51789-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 678bea1) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a followup of #50575 that sets the initial Spark Connect mode by reading
SPARK_CONNECT_MODE.Why are the changes needed?
In Spark 4.0 release (Spark Connect distribution),
starts Spark Classic shells.
Does this PR introduce any user-facing change?
No to end users because the main change has not been released yet.
How was this patch tested?
Manually tested with some combinations below:
Was this patch authored or co-authored using generative AI tooling?
No.