Let pyspark execute files even when IPYTHON=1 #515
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove IPYTHON_OPTS
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
|
Because this won't work on IPython < 2, we unfortunately can't merge it. You should just file an issue in https://issues.apache.org/jira/browse/SPARK and we will revisit it when IPython 2 has much broader adoption. Unfortunately for a while lots of people will probably still be on 1. |
|
If you can figure out a way to retain backwards-compatibility with IPython < 2, I'd be happy to merge this. Maybe you can do something like parsing |
bzhaoopenstack
pushed a commit
to bzhaoopenstack/spark
that referenced
this pull request
Sep 11, 2019
As per the issue kubernetes/kubernetes#77521 (comment), issue seems to be happen only when KUBE_FASTBUILD=true. Changing the same to check if it fixes the e2e job.
bzhaoopenstack
pushed a commit
to bzhaoopenstack/spark
that referenced
this pull request
Sep 11, 2019
This reverts commit acd5e29.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of IPython 2.0 having the
PYTHONSTARTUPenvironment variable and passing a file at the same time works as expected. So, we can just pass the commandline args straight to IPython.Also remove
IPYTHON_OPTS, as you can now just pass options to IPython directlyThis puts the behavior of
IPYTHON=1in line with the regular Python interpreterNote that this won't work correctly when IPython version < 2.0