[SPARK-53678][SQL] Fix NPE when subclass of ColumnVector is created with null DataType #52423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thank you, @manuzhang . Could you rebase to the master branch once more? Previously, master branch compilation was broken accidentally and now it's recovered.
…ith null DataType
manuzhang
force-pushed
the
SPARK-53678
branch
from
466acaf to
f840327
Compare
|
@dongjoon-hyun Rebased. Please help review. |
yaooqinn
approved these changes
Sep 24, 2025
dongjoon-hyun
approved these changes
Sep 24, 2025
There was a problem hiding this comment.
+1, LGTM. Thank you, @manuzhang and @yaooqinn .
Merged to master.
|
Due to the conflicts, this PR landed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Check whether the parameter DataType is null in ColumnVector constructor before transforming it
Why are the changes needed?
A subclass of ColumnVector, e.g. Iceberg's ConstantColumnVector, could be created with null
DataType. It throws NPE after #51349, which can be verified by failed tests in integrating Spark 4.1.0-preview1 in IcebergDoes this PR introduce any user-facing change?
No.
How was this patch tested?
UT.
Was this patch authored or co-authored using generative AI tooling?
No.