Skip to content

[SPARK-53961][SQL][TESTS] Fix FileStreamSinkSuite flakiness by using walkFileTree instead of walk #52671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-53961][SQL][TESTS] Fix FileStreamSinkSuite flakiness by using walkFileTree instead of walk #52671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSinkSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package org.apache.spark.sql.streaming

import java.io.{File, IOException}
import java.nio.file.{Files, Paths}
import java.nio.file.attribute.BasicFileAttributes
import java.util.Locale

import scala.collection.mutable.ArrayBuffer
Expand Down Expand Up @@ -534,10 +535,25 @@ abstract class FileStreamSinkSuite extends StreamTest {
}

import PendingCommitFilesTrackingManifestFileCommitProtocol._
val outputFileNames = Files.walk(outputDir.toPath).iterator().asScala
.filter(_.toString.endsWith(".parquet"))
.map(_.getFileName.toString)
.toSet
import java.nio.file.{Path, _}
val outputFileNames = scala.collection.mutable.Set.empty[String]
Files.walkFileTree(
outputDir.toPath,
new SimpleFileVisitor[Path] {
override def visitFile(file: Path, attrs: BasicFileAttributes): FileVisitResult = {
val fileName = file.getFileName.toString
if (fileName.endsWith(".parquet")) outputFileNames += fileName
FileVisitResult.CONTINUE
}
override def visitFileFailed(file: Path, exc: IOException): FileVisitResult = {
exc match {
case _: NoSuchFileException =>
FileVisitResult.CONTINUE
Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay to ignore the deleted files because those are supposed to be cleaned up in a success case.

case _ =>
FileVisitResult.TERMINATE
}
}
})
val trackingFileNames = tracking.map(SparkPath.fromUrlString(_).toPath.getName).toSet

// there would be possible to have race condition:
Expand Down