[SPARK-54211][PYTHON][FOLLOW-UP] Fix doctests of mapInArrow #52965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you so much, @zhengruifeng .
dongjoon-hyun
changed the title
Contributor
|
Merged into master. Thanks @zhengruifeng and @dongjoon-hyun |
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 22, 2025
### What changes were proposed in this pull request?
Fix doctests of mapInArrow
### Why are the changes needed?
to make CI happy
```
batch.filter(pa.compute.field("id") == 1)
```
the expression input `pa.compute.field("id") == 1` is supported since pyarrow 17.0
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
PR builder with
```
default: '{"PYSPARK_IMAGE_TO_TEST": "python-minimum", "PYTHON_TO_TEST": "python3.10"}'
```
see https://github.com/zhengruifeng/spark/actions/runs/19222092639/job/54941916951
### Was this patch authored or co-authored using generative AI tooling?
NO
Closes apache#52965 from zhengruifeng/fix_map_in_arrow_doctest.
Authored-by: Ruifeng Zheng <ruifengz@apache.org>
Signed-off-by: yangjie01 <yangjie01@baidu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix doctests of mapInArrow
Why are the changes needed?
to make CI happy
the expression input
pa.compute.field("id") == 1is supported since pyarrow 17.0Does this PR introduce any user-facing change?
No
How was this patch tested?
PR builder with
see https://github.com/zhengruifeng/spark/actions/runs/19222092639/job/54941916951
Was this patch authored or co-authored using generative AI tooling?
NO