[SPARK-54319][SQL] BHJ LeftAnti update numOutputRows wrong when codegen is disabled #53014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
|
ping @cloud-fan @dongjoon-hyun @HyukjinKwon Could you take a review |
cloud-fan
approved these changes
Nov 17, 2025
Contributor
|
thanks, merging to master/4.1! |
cloud-fan
pushed a commit
that referenced
this pull request
Nov 17, 2025
…en is disabled ### What changes were proposed in this pull request? BHJ LeftAnti update numOutputRows missing case for hashed = EmptyHashedRelation <img width="1754" height="1148" alt="image" src="https://github.com/user-attachments/assets/a71e4546-578e-4e4d-9434-9287074ebe75" /> ### Why are the changes needed? Fix missing sql metrics for BHJ ### Does this PR introduce _any_ user-facing change? Yes, BHJ LeftAnti will update numOutputRows when hashed = EmptyHashedRelation ### How was this patch tested? Existed UT ### Was this patch authored or co-authored using generative AI tooling? No Closes #53014 from AngersZhuuuu/SPARK-54319. Authored-by: Angerszhuuuu <angers.zhu@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 3757091) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Member
|
Thank you, @AngersZhuuuu and @cloud-fan . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
BHJ LeftAnti update numOutputRows missing case for hashed = EmptyHashedRelation
Why are the changes needed?
Fix missing sql metrics for BHJ
Does this PR introduce any user-facing change?
Yes, BHJ LeftAnti will update numOutputRows when hashed = EmptyHashedRelation
How was this patch tested?
Existed UT
Was this patch authored or co-authored using generative AI tooling?
No