[SPARK-54163][SQL] Scan canonicalization for partitioning and ordering info #53105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengliangwang
approved these changes
Nov 18, 2025
Member
|
Thanks, merging to master/4.1 |
gengliangwang
pushed a commit
that referenced
this pull request
Nov 18, 2025
…g info ### What changes were proposed in this pull request? This PR extends current canonicalization function for DataSourceV2ScanRelation to normalize the keyGroupedPartitioning and ordering field. Therefore it can apply to partition/ordering-aware data sources. ### Why are the changes needed? In order to apply canonicalization to partition/ordering-aware data sources. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Unit tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53105 from yhuang-db/SPARK-54163-canonicalization-normalization. Authored-by: yhuang-db <itisyuchuan@gmail.com> Signed-off-by: Gengliang Wang <gengliang@apache.org> (cherry picked from commit 1012a5f) Signed-off-by: Gengliang Wang <gengliang@apache.org>
Member
|
So, this landed as a kind of follow-up bug fix of this, @gengliangwang ? |
Member
|
@dongjoon-hyun yes. When |
Member
|
Got it. Thank you, @gengliangwang . +1 for your decision. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR extends current canonicalization function for DataSourceV2ScanRelation to normalize the keyGroupedPartitioning and ordering field. Therefore it can apply to partition/ordering-aware data sources.
Why are the changes needed?
In order to apply canonicalization to partition/ordering-aware data sources.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit tests.
Was this patch authored or co-authored using generative AI tooling?
No.