-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-51765][DOCS] Document SQL Scripting Syntax
#53155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-51765][DOCS] Document SQL Scripting Syntax
#53155
Conversation
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for polishing the feature with the documentation and proposing this, @davidm-db .
As a release manager, I'll block this until I re-verify this again. For now, please consider this as -1 because there is not enough time for the community to re-evaluate your suggestion yet.
I don't think this is a blocker for Apache Spark 4.1.0 itself. We can put this and the documentation as a part of Apache Spark 4.2.0 also.
SQL Scripting Syntax
|
Thank you, @davidm-db . |
|
Merged to master. There is a conflict on branch-4.1. Could you make a backporting PR to |
|
@dongjoon-hyun I created a backport PR to Even if we don't enable Scripting by default in 4.1, there's no reason to not have docs in. At least I think so, because feature can be used by enabling the flag. I just added a minor note there on how to enable SQL Scripting (i.e. which flag to set), since it's not enabled by default. |
Porting #53155 to `branch-4.1` and resolving merge conflicts. The only difference is a minor note in `docs/sql-ref-scripting.md` on how to enable SQL Scripting, since it's not enabled by default in Spark 4.1. ### What changes were proposed in this pull request? Adding documentation for SQL Scripting feature. ### Why are the changes needed? If it is not documented, it never happened :-) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Documentation change, reviewed manually. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53194 from davidm-db/scripting-docs-4.1. Lead-authored-by: Serge Rielau <serge@rielau.com> Co-authored-by: David Milicevic <david.milicevic@databricks.com> Co-authored-by: David Milicevic <163021185+davidm-db@users.noreply.github.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Recreation of #50592, updated to reflect the current state of the feature.
What changes were proposed in this pull request?
Adding documentation for SQL Scripting feature.
Why are the changes needed?
If it is not documented, it never happened :-)
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Documentation change, reviewed manually.
Was this patch authored or co-authored using generative AI tooling?
No.