Skip to content

Conversation

@davidm-db
Copy link
Contributor

Recreation of #50592, updated to reflect the current state of the feature.

What changes were proposed in this pull request?

Adding documentation for SQL Scripting feature.

Why are the changes needed?

If it is not documented, it never happened :-)

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Documentation change, reviewed manually.

Was this patch authored or co-authored using generative AI tooling?

No.

@davidm-db
Copy link
Contributor Author

cc @cloud-fan @dongjoon-hyun

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for polishing the feature with the documentation and proposing this, @davidm-db .

As a release manager, I'll block this until I re-verify this again. For now, please consider this as -1 because there is not enough time for the community to re-evaluate your suggestion yet.

I don't think this is a blocker for Apache Spark 4.1.0 itself. We can put this and the documentation as a part of Apache Spark 4.2.0 also.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-51765][DOCS] Docs for SQL Scripting [SPARK-51765][DOCS] Document SQL Scripting Syntax Nov 21, 2025
@dongjoon-hyun
Copy link
Member

Thank you, @davidm-db .

@dongjoon-hyun
Copy link
Member

Merged to master.

There is a conflict on branch-4.1. Could you make a backporting PR to branch-4.1 (if you want to have this in Apache Spark 4.1.0), @davidm-db ?

@davidm-db
Copy link
Contributor Author

davidm-db commented Nov 24, 2025

@dongjoon-hyun I created a backport PR to branch-4.1: #53155.

Even if we don't enable Scripting by default in 4.1, there's no reason to not have docs in. At least I think so, because feature can be used by enabling the flag.

I just added a minor note there on how to enable SQL Scripting (i.e. which flag to set), since it's not enabled by default.

cloud-fan pushed a commit that referenced this pull request Nov 24, 2025
Porting #53155 to `branch-4.1` and resolving merge conflicts.

The only difference is a minor note in `docs/sql-ref-scripting.md` on how to enable SQL Scripting, since it's not enabled by default in Spark 4.1.

### What changes were proposed in this pull request?

Adding documentation for SQL Scripting feature.

### Why are the changes needed?

If it is not documented, it never happened :-)

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Documentation change, reviewed manually.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #53194 from davidm-db/scripting-docs-4.1.

Lead-authored-by: Serge Rielau <serge@rielau.com>
Co-authored-by: David Milicevic <david.milicevic@databricks.com>
Co-authored-by: David Milicevic <163021185+davidm-db@users.noreply.github.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants