[SPARK-54468][SDP] Add missing error classes #53186
Open
+18
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@sryza Have a look and LMK if new tests should be added. Happy to learn how to add them if needed. Please guide 🙏 |
| "message" : [ | ||
| "Invalid destination <tableName> with multiple flows: <flows>." | ||
| ], | ||
| "sqlState" : "42000" |
Contributor
There was a problem hiding this comment.
Can we provide a more specific SQL state?
| "message" : [ | ||
| "Pipeline graph must be topologically sorted (flow <flowName> with unvisited input <inputName>)" | ||
| ], | ||
| "sqlState" : "42000" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added two missing error classes
Why are the changes needed?
MATERIALIZED_VIEW_WITH_MULTIPLE_QUERIESandPIPELINE_GRAPH_NOT_TOPOLOGICALLY_SORTEDerror classes were not defined yet used in SDP.Does this PR introduce any user-facing change?
Sort of. It fixes what should be reported properly with the error classes.
How was this patch tested?
Built locally. Awaiting the official build to pass
Was this patch authored or co-authored using generative AI tooling?
No